chrome/browser/resources/extensions/extensions.html - Issue 9705083: Unknown options in extension manifest file are silently ignored

Side by Side Diff: chrome/browser/resources/extensions/extensions.html

Issue 9705083: Unknown options in extension manifest file are silently ignored (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Removed an accedentally-included file Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/extensions/extension_list.js ('K') | « chrome/browser/resources/extensions/extensions.css ('k') | chrome/browser/ui/webui/options/extension_settings_handler.cc » ('j') | chrome/browser/ui/webui/options/extension_settings_handler.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html i18n-values="dir:textdirection;" class="loading">	2 <html i18n-values="dir:textdirection;" class="loading">

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5	5

6 <link rel="icon" href="chrome://theme/IDR_EXTENSIONS_FAVICON">	6 <link rel="icon" href="chrome://theme/IDR_EXTENSIONS_FAVICON">

7 <link rel="stylesheet" href="extensions.css">	7 <link rel="stylesheet" href="extensions.css">

8 <link rel="stylesheet" href="pack_extension_overlay.css">	8 <link rel="stylesheet" href="pack_extension_overlay.css">

9 <link rel="stylesheet" href="../shared/css/alert_overlay.css">	9 <link rel="stylesheet" href="../shared/css/alert_overlay.css">

10 <link rel="stylesheet" href="../shared/css/chrome_shared2.css">	10 <link rel="stylesheet" href="../shared/css/chrome_shared2.css">

(...skipping 69 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
80 <span i18n-content="extensionSettingsExtensionPath"></span>	80 <span i18n-content="extensionSettingsExtensionPath"></span>

81 <span></span>	81 <span></span>

82 </div>	82 </div>

83 <div class="managed-message"	83 <div class="managed-message"

84 i18n-content="extensionSettingsPolicyControlled" hidden>	84 i18n-content="extensionSettingsPolicyControlled" hidden>

85 </div>	85 </div>

86 <div class="active-views" hidden>	86 <div class="active-views" hidden>

87 <span i18n-content="extensionSettingsInspectViews"></span>	87 <span i18n-content="extensionSettingsInspectViews"></span>

88 <a href="#"></a>	88 <a href="#"></a>

89 </div>	89 </div>

	90 <div class="unrecognized-keys" hidden>

	91 <span i18n-content="extensionSettingsExtensionUnrecognizedKeys"></sp an>
	James Hawkins 2012/04/08 20:33:23 nit: 80 cols. nit: 80 cols. mitchellwrosen 2012/04/28 19:02:39 Done. Show quoted text On 2012/04/08 20:33:23, James Hawkins wrote: > nit: 80 cols. Done.
	92 <span></span>
	James Hawkins 2012/04/08 20:33:23 What's with the empty span? What's with the empty span? not at google - send to devlin 2012/04/10 02:02:32 Looks like this is a target for the content. If yo Show quoted text On 2012/04/08 20:33:23, James Hawkins wrote: > What's with the empty span? Looks like this is a target for the content. If you follow my suggestion in the JS, make this an <ul> with a quick comment explaining that? mitchellwrosen 2012/04/28 19:02:39 Done. Show quoted text On 2012/04/10 02:02:32, kalman wrote: > On 2012/04/08 20:33:23, James Hawkins wrote: > > What's with the empty span? > > Looks like this is a target for the content. If you follow my suggestion in the > JS, make this an <ul> with a quick comment explaining that? Done.
	93 </div>

90 </div>	94 </div>

91 <div class="optional-controls">	95 <div class="optional-controls">

92 <button class="show-button"	96 <button class="show-button"

93 i18n-content="extensionSettingsShowButton" hidden ></button>	97 i18n-content="extensionSettingsShowButton" hidden ></button>

94 <div class="checkbox"><label class="incognito-control">	98 <div class="checkbox"><label class="incognito-control">

95 <input type="checkbox">	99 <input type="checkbox">

96 <span i18n-content="extensionSettingsEnableIncognito"></span>	100 <span i18n-content="extensionSettingsEnableIncognito"></span>

97 </label></div>	101 </label></div>

98 <label class="file-access-control" hidden>	102 <label class="file-access-control" hidden>

99 <input type="checkbox">	103 <input type="checkbox">

(...skipping 31 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
131 <include src="../shared/html/trash.html">	135 <include src="../shared/html/trash.html">

132	136

133 </div>	137 </div>

134	138

135 <script src="chrome://extensions-frame/strings.js"></script>	139 <script src="chrome://extensions-frame/strings.js"></script>

136 <script src="chrome://resources/js/i18n_template.js"></script>	140 <script src="chrome://resources/js/i18n_template.js"></script>

137 <script src="chrome://resources/js/i18n_process.js"></script>	141 <script src="chrome://resources/js/i18n_process.js"></script>

138	142

139 </body>	143 </body>

140 </html>	144 </html>

OLD	NEW