Unknown options in extension manifest file are silently ignored

chrome/common/extensions/manifest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/manifest.h"
 
 #include "base/basictypes.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/string_split.h"
+#include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/common/extensions/extension_manifest_constants.h"
 #include "chrome/common/extensions/extension_error_utils.h"
 #include "chrome/common/extensions/simple_feature_provider.h"
 
 namespace errors = extension_manifest_errors;
 namespace keys = extension_manifest_keys;
 
 namespace extensions {
 
 Manifest::Manifest(Extension::Location location,
                    scoped_ptr<DictionaryValue> value)
     : location_(location), value_(value.Pass()) {
 }
 
 Manifest::~Manifest() {
 }
 
 void Manifest::ValidateManifest(std::vector<std::string>* warnings) const {
-  // Check every feature to see if its in the manifest. Note that this means
-  // we will ignore keys that are not features; we do this for forward
-  // compatibility.
-  // TODO(aa): Consider having an error here in the case of strict error
-  // checking to let developers know when they screw up.
-
+  // Check every feature to see if its in the manifest.
   std::set<std::string> feature_names =
       SimpleFeatureProvider::GetManifestFeatures()->GetAllFeatureNames();
   for (std::set<std::string>::iterator feature_name = feature_names.begin();
        feature_name != feature_names.end(); ++feature_name) {
     // Use Get instead of HasKey because the former uses path expansion.
     if (!value_->Get(*feature_name, NULL))
       continue;
 
     Feature* feature =
         SimpleFeatureProvider::GetManifestFeatures()->GetFeature(*feature_name);
     Feature::Availability result = feature->IsAvailableToManifest(
         extension_id_, GetType(), Feature::ConvertLocation(location_),
         GetManifestVersion());
     if (result != Feature::IS_AVAILABLE)
       warnings->push_back(feature->GetErrorMessage(result));
   }
+
+  // Also generate warnings for keys that are not features.
+  for (DictionaryValue::key_iterator key = value_->begin_keys();
+      key != value_->end_keys(); ++key) {
+    if (!SimpleFeatureProvider::GetManifestFeatures()->GetFeature(*key)) {
+      warnings->push_back(base::StringPrintf("Unrecognized manifest key '%s'.",
+          (*key).c_str()));

[not at google - send to devlin, 2012/05/01 04:04:01]

key->c_str()

[mitchellwrosen, 2012/05/01 04:18:47]

But key's a key_iterator, not a std::string*

+    }
+  }
 }
 
 bool Manifest::HasKey(const std::string& key) const {
   return CanAccessKey(key) && value_->HasKey(key);
 }
 
 bool Manifest::Get(
     const std::string& path, Value** out_value) const {
   return CanAccessPath(path) && value_->Get(path, out_value);
 }
@@ skipping 97 matching lines @@
       SimpleFeatureProvider::GetManifestFeatures()->GetFeature(key);
   if (!feature)
     return true;
 
   return Feature::IS_AVAILABLE == feature->IsAvailableToManifest(
       extension_id_, GetType(), Feature::ConvertLocation(location_),
       GetManifestVersion());
 }
 
 }  // namespace extensions