Issue 9705053: Remove tab_contents_view_gtk.h include from chrome. I tried to find a way to not have to expose the…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9705053: Remove tab_contents_view_gtk.h include from chrome. I tried to find a way to not have to expose the… (Closed)

Created:
8 years, 9 months ago by jam

Modified:
8 years, 9 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove tab_contents_view_gtk.h include from chrome. I tried to find a way to not have to expose the FocusStore to the delegate, but I couldn't find any other way. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126926

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -30 lines)			Patch
M	chrome/browser/DEPS	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/chrome_web_contents_view_delegate_gtk.h	View		3 chunks	+11 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/chrome_web_contents_view_delegate_gtk.cc	View	1 2	3 chunks	+25 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/constrained_window_gtk.cc	View	1	4 chunks	+3 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/sad_tab_helper.cc	View	1	3 chunks	+9 lines, -9 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents_view_gtk.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents_view_gtk.cc	View	1	2 chunks	+1 line, -5 lines	0 comments	Download
M	content/public/browser/web_contents_view_delegate.h	View		2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages