Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 9705052: Revert 126777 - Broke 'win' trybot (shared + all = fails linking pyautolib due to over swigging) (Closed)

Created:
8 years, 9 months ago by Ryan Sleevi
Modified:
8 years, 9 months ago
Reviewers:
dyu1
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh
Visibility:
Public.

Description

Revert 126777 - Broke 'win' trybot (shared + all = fails linking pyautolib due to over swigging) Exposed GetSecurityState and GetPageType to pyAuto. The GetSecurityState retrieves different security states for the current tab. The GetPageType returns the type of page showing (normal, interstitial, error). Added additional tests that uses the exposed hooks. - testSSLCertOK - testSSLCertIsExpiredAndCertNameMismatches - testSSLCertAuthorityOK TEST=none BUG=none Review URL: https://chromiumcodereview.appspot.com/9535022 TBR=dyu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126848

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -93 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/test/functional/https.py View 2 chunks +1 line, -41 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.i View 4 chunks +1 line, -47 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ryan Sleevi
8 years, 9 months ago (2012-03-15 05:21:40 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698