runtime/vm/code_generator.cc - Issue 9705041: Fix 2172: report 'int' instead of Smi, Mint and Bigint when throwing TypeError.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/code_generator.cc

Issue 9705041: Fix 2172: report 'int' instead of Smi, Mint and Bigint when throwing TypeError. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/code_generator.cc

===================================================================

--- runtime/vm/code_generator.cc (revision 5480)

+++ runtime/vm/code_generator.cc (working copy)

@@ -467,7 +467,13 @@

}

if (!is_instance_of) {

const Type& src_type = Type::Handle(src_instance.GetType());

- const String& src_type_name = String::Handle(src_type.Name());

+ String& src_type_name = String::Handle();

+ if (src_instance.IsInteger()) {

+ // Hide implementation detail (Smi, Mint, Bigint).

+ src_type_name = String::NewSymbol("int");

+ } else {

+ src_type_name = src_type.Name();

+ }

String& dst_type_name = String::Handle();

if (!dst_type.IsInstantiated()) {

// Instantiate dst_type before reporting the error.

« no previous file with comments | « no previous file | tests/language/src/TypeVMTest.dart » ('j') | no next file with comments »