Issue 9705039: Makes escape cancel a snap operation from the maximize button.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9705039: Makes escape cancel a snap operation from the maximize button. (Closed)

Created:
8 years, 9 months ago by sky

Modified:
8 years, 9 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Makes escape cancel a snap operation from the maximize button. BUG=116213 TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126908

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+100 lines, -3 lines)			Patch
	M	ash/wm/workspace/frame_maximize_button.h	View		3 chunks	+11 lines, -0 lines	0 comments	Download
	M	ash/wm/workspace/frame_maximize_button.cc	View		6 chunks	+89 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/9705039/1

8 years, 9 months ago (2012-03-15 00:21:32 UTC) #3

commit-bot: I haz the power

8 years, 9 months ago (2012-03-15 04:05:22 UTC) #4

Try job failure for 9705039-1 (previous was lost) (previous was lost) (retry) on
win for step "compile" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Expand Messages | Collapse Messages