Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: frog/leg/resolver.dart

Issue 9705025: const constructors with optional arguments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: frog/leg/resolver.dart
diff --git a/frog/leg/resolver.dart b/frog/leg/resolver.dart
index 3b5390ad5fec7e21a9e4e231c73c5156450a5902..1ab617a065ee45820ca71222121bafdcc3f11e57 100644
--- a/frog/leg/resolver.dart
+++ b/frog/leg/resolver.dart
@@ -805,6 +805,7 @@ class ResolverVisitor extends CommonResolverVisitor<Element> {
void handleArguments(Send node) {
int count = 0;
List<SourceString> namedArguments = <SourceString>[];
+ bool seenNamedArgument = false;
for (Link<Node> link = node.argumentsNode.nodes;
!link.isEmpty();
link = link.tail) {
@@ -812,8 +813,11 @@ class ResolverVisitor extends CommonResolverVisitor<Element> {
Expression argument = link.head;
visit(argument);
if (argument.asNamedArgument() != null) {
+ seenNamedArgument = true;
NamedArgument named = argument;
namedArguments.add(named.name.source);
+ } else if (seenNamedArgument) {
+ error(argument, MessageKind.INVALID_ARGUMENT_AFTER_NAMED);
}
}
mapping.setSelector(node, new Invocation(count, namedArguments));

Powered by Google App Engine
This is Rietveld 408576698