Chromium Code Reviews Chromium Code Reviews
Issue
9705021:
Clean up TemplateURL prepopulate data: (Closed)
DescriptionClean up TemplateURL prepopulate data:
* Replace a pair of overlapping functions in the API with two distinct accessors for relevant pieces of information about prepopulated URLs. One key side effect here is that we no longer return TemplateURL*s from these, which will make the upcoming refactoring changes slightly cleaner.
* Make the implementation of these a bit more robust w.r.t. determining if a provided URL corresponds to Google. This will also be important later as we'll want to be able to match a hand-coded "google.co.uk" entry against an auto-generated "google.de" entry (or similar).
* Remove a bunch of string conversions, as well as a lot of passing of raw C-style string pointers.
* Remove using statements.
* Remove two obscure engines which have the same hostname as another, different engine. These cause problems when we ask for the name or type of an engine because the answer we get back is basically indeterminate. I don't think either of these is very important (they lived at slots 4 and 5 in their respective countries) so just gut them.
BUG=none
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126746
Patch Set 1 #Patch Set 2 : #
Total comments: 2
Patch Set 3 : #
Messages
Total messages: 4 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
