Making the selectedIndex property setters of ListSelectionModel and ListSingleSelectionModel behave…

Making the selectedIndex property setters of ListSelectionModel and ListSingleSelectionModel behave consistently.

Also now language list has leadItem when appears first time.

BUG=chromium:117883
TEST=Test single selection lists: cookies, languages, profiles.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126876

[arv (Not doing code reviews), 2012-03-14 17:54:36]

I'm curious why we want to make this change?

[SeRya, 2012-03-14 18:03:43]

On 2012/03/14 17:54:36, arv wrote:
> I'm curious why we want to make this change?

To fix the bug.

[arv (Not doing code reviews), 2012-03-14 18:13:09]

On 2012/03/14 18:03:43, SeRya wrote:
> On 2012/03/14 17:54:36, arv wrote:
> > I'm curious why we want to make this change?
> 
> To fix the bug.

This doesn't seem like the right way to fix this. I assume that the expansion
happens when the leadItem changes and somehow someone regressed the lists to not
set the lead item correctly. By making this change I'm concerned that it might
regress something else.

[SeRya, 2012-03-14 18:33:43]

On 2012/03/14 18:13:09, arv wrote:
> On 2012/03/14 18:03:43, SeRya wrote:
> > On 2012/03/14 17:54:36, arv wrote:
> > > I'm curious why we want to make this change?
> > 
> > To fix the bug.
> 
> This doesn't seem like the right way to fix this. I assume that the expansion
> happens when the leadItem changes and somehow someone regressed the lists to
not
> set the lead item correctly. By making this change I'm concerned that it might
> regress something else.

Regression happened because I simplified code in list_selection_model.js in this
CL: https://chromiumcodereview.appspot.com/9429003/. Simplified code works
identically for multi-selection list. But in single selection it leaves
leadIndex unchanged. This change makes assignment to selectedIndex be enough for
single-selection as well so it's complete fix.

Expansion happens when the item is both lead and selected.

[arv (Not doing code reviews), 2012-03-14 18:50:03]

LGTM

OK. You have convinced me that this should be safe.

[commit-bot: I haz the power, 2012-03-14 19:09:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/serya@chromium.org/9705015/1

[commit-bot: I haz the power, 2012-03-14 22:02:03]

Try job failure for 9705015-1 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-03-15 05:21:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/serya@chromium.org/9705015/1

[commit-bot: I haz the power, 2012-03-15 06:42:00]

Try job failure for 9705015-1 (retry) on win for step "compile" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[Dan Beam, 2012-03-15 09:50:11]

thanks for the quick turn around, serya!