Issue 9705010: ChromeOS language overlay: Move cancel button to the right

Issue 9705010: ChromeOS language overlay: Move cancel button to the right (Closed)

Created:
8 years, 9 months ago by Tyler Breisacher (Chromium)

Modified:
8 years, 9 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ChromeOS language overlay: Move cancel button to the right BUG=117959 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126689

Patch Set 2 : use button-strip #

Total comments: 1

Patch Set 3 : get rid of unnecessary CSS #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -11 lines)			Patch
	M	chrome/browser/resources/options2/language_add_language_overlay.html	View	1	1 chunk	+10 lines, -4 lines	1 comment	Download
	M	chrome/browser/resources/options2/language_options.css	View	1 2	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

Cancel button should be on the right using button-strip.

8 years, 9 months ago (2012-03-14 03:25:01 UTC) #2

Tyler Breisacher (Chromium)

On 2012/03/14 03:25:01, James Hawkins wrote: > Cancel button should be on the right using ...

8 years, 9 months ago (2012-03-14 18:10:56 UTC) #3

Tyler Breisacher (Chromium)

http://codereview.chromium.org/9705010/diff/5001/chrome/browser/resources/options2/language_options.css File chrome/browser/resources/options2/language_options.css (right): http://codereview.chromium.org/9705010/diff/5001/chrome/browser/resources/options2/language_options.css#newcode148 chrome/browser/resources/options2/language_options.css:148: margin-top: 15px; And actually we don't need this anymore ...

8 years, 9 months ago (2012-03-14 18:13:17 UTC) #4

James Hawkins

http://codereview.chromium.org/9705010/diff/1003/chrome/browser/resources/options2/language_add_language_overlay.html File chrome/browser/resources/options2/language_add_language_overlay.html (right): http://codereview.chromium.org/9705010/diff/1003/chrome/browser/resources/options2/language_add_language_overlay.html#newcode11 chrome/browser/resources/options2/language_add_language_overlay.html:11: i18n-content="cancel"></button> Two nits in one! * Indentation should be ...

8 years, 9 months ago (2012-03-14 18:17:46 UTC) #5

LGTM with nits.

Expand Messages | Collapse Messages