Adds a device policy to specify the set of initial urls for the demo user account.

Adds a device policy to specify the set of initial urls for the demo user account.

BUG=chromium-os:26249
TEST=Set the policy and observe the pages load only for the demo user. Also visible in about:policy.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127463

[pastarmovj, 2012-03-16 15:38:20]

And a CL for you for review :)

[Joao da Silva, 2012-03-16 15:55:18]

lgtm after fixing the issues below.

http://codereview.chromium.org/9704092/diff/1/chrome/app/policy/policy_templa...
File chrome/app/policy/policy_templates.json (right):

http://codereview.chromium.org/9704092/diff/1/chrome/app/policy/policy_templa...
chrome/app/policy/policy_templates.json:2443: 'id': 135,
We have a race for this id :-)

http://codereview.chromium.org/9704092/diff/1/chrome/app/policy/policy_templa...
chrome/app/policy/policy_templates.json:2445: 'desc': '''Determines the set of
URLs to be loaded when the demo session is started. This policy will override
any other mechanisms for setting the initial URL and thus can only be applied to
a session not associated with a particular user.''',
The first phrase should be the same as for the other kiosk mode policies:

"This policy is active in retail mode only."

http://codereview.chromium.org/9704092/diff/1/chrome/browser/chromeos/device_...
File chrome/browser/chromeos/device_settings_provider.cc (right):

http://codereview.chromium.org/9704092/diff/1/chrome/browser/chromeos/device_...
chrome/browser/chromeos/device_settings_provider.cc:451:
new_values_cache->SetValue(kStartUpUrls, list);
Wrap this block with if (policy.has_start_up_urls()) { ... }

http://codereview.chromium.org/9704092/diff/1/chrome/browser/chromeos/login/e...
File chrome/browser/chromeos/login/existing_user_controller.cc (right):

http://codereview.chromium.org/9704092/diff/1/chrome/browser/chromeos/login/e...
chrome/browser/chromeos/login/existing_user_controller.cc:733: #if 0
O.O

http://codereview.chromium.org/9704092/diff/1/chrome/browser/policy/device_po...
File chrome/browser/policy/device_policy_cache.cc (right):

http://codereview.chromium.org/9704092/diff/1/chrome/browser/policy/device_po...
chrome/browser/policy/device_policy_cache.cc:554: POLICY_SCOPE_MACHINE, urls);
Break after the , in both lines for consistency with the rest of the file.

http://codereview.chromium.org/9704092/diff/1/chrome/browser/policy/proto/chr...
File chrome/browser/policy/proto/chrome_device_policy.proto (right):

http://codereview.chromium.org/9704092/diff/1/chrome/browser/policy/proto/chr...
chrome/browser/policy/proto/chrome_device_policy.proto:164: // Specifies the
URLs to be loaded on login to the anonymous account used  if
Nitty nit: double spaces before the "if"

[Joao da Silva, 2012-03-16 18:13:42]

FYI, http://crrev.com/127203 uses policy ids 135 and 136.

[pastarmovj, 2012-03-19 14:20:49]

Addressed issues...committing.

http://codereview.chromium.org/9704092/diff/1/chrome/app/policy/policy_templa...
File chrome/app/policy/policy_templates.json (right):

http://codereview.chromium.org/9704092/diff/1/chrome/app/policy/policy_templa...
chrome/app/policy/policy_templates.json:2443: 'id': 135,
On 2012/03/16 15:55:18, Joao da Silva wrote:
> We have a race for this id :-)

Done.

http://codereview.chromium.org/9704092/diff/1/chrome/app/policy/policy_templa...
chrome/app/policy/policy_templates.json:2445: 'desc': '''Determines the set of
URLs to be loaded when the demo session is started. This policy will override
any other mechanisms for setting the initial URL and thus can only be applied to
a session not associated with a particular user.''',
On 2012/03/16 15:55:18, Joao da Silva wrote:
> The first phrase should be the same as for the other kiosk mode policies:
> 
> "This policy is active in retail mode only."

Done.

http://codereview.chromium.org/9704092/diff/1/chrome/browser/chromeos/device_...
File chrome/browser/chromeos/device_settings_provider.cc (right):

http://codereview.chromium.org/9704092/diff/1/chrome/browser/chromeos/device_...
chrome/browser/chromeos/device_settings_provider.cc:451:
new_values_cache->SetValue(kStartUpUrls, list);
On 2012/03/16 15:55:18, Joao da Silva wrote:
> Wrap this block with if (policy.has_start_up_urls()) { ... }

Done.

http://codereview.chromium.org/9704092/diff/1/chrome/browser/chromeos/login/e...
File chrome/browser/chromeos/login/existing_user_controller.cc (right):

http://codereview.chromium.org/9704092/diff/1/chrome/browser/chromeos/login/e...
chrome/browser/chromeos/login/existing_user_controller.cc:733: #if 0
On 2012/03/16 15:55:18, Joao da Silva wrote:
> O.O

Not me :) This code just shifted two spaces inward. Mine is only the if block
not the else.

http://codereview.chromium.org/9704092/diff/1/chrome/browser/policy/device_po...
File chrome/browser/policy/device_policy_cache.cc (right):

http://codereview.chromium.org/9704092/diff/1/chrome/browser/policy/device_po...
chrome/browser/policy/device_policy_cache.cc:554: POLICY_SCOPE_MACHINE, urls);
On 2012/03/16 15:55:18, Joao da Silva wrote:
> Break after the , in both lines for consistency with the rest of the file.

Done.

http://codereview.chromium.org/9704092/diff/1/chrome/browser/policy/proto/chr...
File chrome/browser/policy/proto/chrome_device_policy.proto (right):

http://codereview.chromium.org/9704092/diff/1/chrome/browser/policy/proto/chr...
chrome/browser/policy/proto/chrome_device_policy.proto:164: // Specifies the
URLs to be loaded on login to the anonymous account used  if
On 2012/03/16 15:55:18, Joao da Silva wrote:
> Nitty nit: double spaces before the "if"

Done.