Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Unified Diff: tools/create_sdk.py

Issue 9704067: Move print from builtin to core in runtime SDK sources only (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/create_sdk.py
===================================================================
--- tools/create_sdk.py (revision 5483)
+++ tools/create_sdk.py (working copy)
@@ -163,8 +163,16 @@
assert builtin_runtime_sources[0] == 'builtin.dart'
copyfile(join(HOME, 'runtime', 'bin', 'builtin.dart'),
join(builtin_dest_dir, 'builtin_runtime.dart'))
+ #
+ # rename the print function in dart:builtin
+ # so that it does not conflict with the print function in dart:core
+ #
+ ReplaceInFiles([
+ join(builtin_dest_dir, 'builtin_runtime.dart')
+ ], [
+ ('void print\(', 'void builtinPrint(')
+ ])
devoncarew 2012/03/15 22:06:26 If I understand the chronology correctly, dart:bui
-
#
# Create and populate lib/io.
#
@@ -341,6 +349,8 @@
for filename in corelib_runtime_sources:
if filename.endswith('.dart'):
dest_file.write('#source("runtime/' + filename + '");\n')
+ # include the missing print function
+ dest_file.write('void print(String arg) { /* native */ }\n')
dest_file.close()
#
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698