Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: runtime/vm/flow_graph_builder.h

Issue 9704063: Simplify translation of conditionals in the flow graph builder. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.h
diff --git a/runtime/vm/flow_graph_builder.h b/runtime/vm/flow_graph_builder.h
index 172bac32fbdfa9325e5ce302ec4c2a8b391da794..7daa2990ad3a00dd09d6102e4bf6e3bee57c0251 100644
--- a/runtime/vm/flow_graph_builder.h
+++ b/runtime/vm/flow_graph_builder.h
@@ -231,25 +231,12 @@ class TestGraphVisitor : public ValueGraphVisitor {
virtual void VisitLiteralNode(LiteralNode* node);
virtual void VisitLoadLocalNode(LoadLocalNode* node);
- bool can_be_true() const {
- // Either both successors are set or neither is set.
- ASSERT((true_successor_address_ == NULL) ==
- (false_successor_address_ == NULL));
- return true_successor_address_ != NULL;
- }
- bool can_be_false() const {
- // Either both successors are set or neither is set.
- ASSERT((true_successor_address_ == NULL) ==
- (false_successor_address_ == NULL));
- return false_successor_address_ != NULL;
- }
-
BlockEntryInstr** true_successor_address() const {
- ASSERT(can_be_true());
+ ASSERT(true_successor_address_ != NULL);
return true_successor_address_;
}
BlockEntryInstr** false_successor_address() const {
- ASSERT(can_be_false());
+ ASSERT(false_successor_address_ != NULL);
return false_successor_address_;
}
« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698