Issue 9704048: Make the content::DOMStorageContext methods callable on the main thread and hide the threading deta…

Issue 9704048: Make the content::DOMStorageContext methods callable on the main thread and hide the threading deta… (Closed)

Created:
8 years, 9 months ago by jam

Modified:
8 years, 9 months ago

Reviewers:
michaeln

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, mihaip+watch_chromium.org, Aaron Boodman

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Make the content::DOMStorageContext methods callable on the main thread and hide the threading details from the embedder. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126835

Patch Set 1 : #

Total comments: 6

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+78 lines, -80 lines)			Patch
M	chrome/browser/browsing_data_local_storage_helper.h	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/browsing_data_local_storage_helper.cc	View	4 chunks	+16 lines, -17 lines	0 comments	Download
M	chrome/browser/browsing_data_remover.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/browsing_data_remover.cc	View	2 chunks	+2 lines, -12 lines	0 comments	Download
M	chrome/browser/extensions/extension_data_deleter.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/extension_data_deleter.cc	View	2 chunks	+2 lines, -13 lines	0 comments	Download
M	content/browser/browser_context.cc	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	content/browser/in_process_webkit/dom_storage_context_impl.h	View	4 chunks	+7 lines, -3 lines	0 comments	Download
M	content/browser/in_process_webkit/dom_storage_context_impl.cc	View	5 chunks	+34 lines, -7 lines	2 comments	Download
M	content/public/browser/dom_storage_context.h	View	2 chunks	+6 lines, -9 lines	4 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

michaeln

can u take a look at this one... https://chromiumcodereview.appspot.com/9667013/

8 years, 9 months ago (2012-03-15 01:24:02 UTC) #3

michaeln

https://chromiumcodereview.appspot.com/9704048/diff/7001/content/public/browser/dom_storage_context.h File content/public/browser/dom_storage_context.h (right): https://chromiumcodereview.appspot.com/9704048/diff/7001/content/public/browser/dom_storage_context.h#newcode34 content/public/browser/dom_storage_context.h:34: virtual void GetAllStorageFiles(GetAllStorageFilesCallback callback) = 0; const ref here?

8 years, 9 months ago (2012-03-15 01:26:01 UTC) #4

michaeln

https://chromiumcodereview.appspot.com/9704048/diff/7001/content/browser/in_process_webkit/dom_storage_context_impl.cc File content/browser/in_process_webkit/dom_storage_context_impl.cc (right): https://chromiumcodereview.appspot.com/9704048/diff/7001/content/browser/in_process_webkit/dom_storage_context_impl.cc#newcode338 content/browser/in_process_webkit/dom_storage_context_impl.cc:338: const std::vector<FilePath>& files, GetAllStorageFilesCallback callback) { const ref here ...

8 years, 9 months ago (2012-03-15 01:43:40 UTC) #5

michaeln

https://chromiumcodereview.appspot.com/9704048/diff/7001/content/public/browser/dom_storage_context.h File content/public/browser/dom_storage_context.h (right): https://chromiumcodereview.appspot.com/9704048/diff/7001/content/public/browser/dom_storage_context.h#newcode28 content/public/browser/dom_storage_context.h:28: virtual ~DOMStorageContext() {} maybe make the dtor protected

8 years, 9 months ago (2012-03-15 02:49:44 UTC) #6

jam

8 years, 9 months ago (2012-03-15 04:06:17 UTC) #7

https://chromiumcodereview.appspot.com/9704048/diff/7001/content/browser/in_p...
File content/browser/in_process_webkit/dom_storage_context_impl.cc (right):

https://chromiumcodereview.appspot.com/9704048/diff/7001/content/browser/in_p...
content/browser/in_process_webkit/dom_storage_context_impl.cc:338: const
std::vector<FilePath>& files, GetAllStorageFilesCallback callback) {
On 2012/03/15 01:43:40, michaeln wrote:
> const ref here too

Done.

https://chromiumcodereview.appspot.com/9704048/diff/7001/content/public/brows...
File content/public/browser/dom_storage_context.h (right):

https://chromiumcodereview.appspot.com/9704048/diff/7001/content/public/brows...
content/public/browser/dom_storage_context.h:28: virtual ~DOMStorageContext() {}
On 2012/03/15 02:49:44, michaeln wrote:
> maybe make the dtor protected

Done.

https://chromiumcodereview.appspot.com/9704048/diff/7001/content/public/brows...
content/public/browser/dom_storage_context.h:34: virtual void
GetAllStorageFiles(GetAllStorageFilesCallback callback) = 0;
On 2012/03/15 01:26:02, michaeln wrote:
> const ref here?

Done.

Expand Messages | Collapse Messages