Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/debugger.cc

Issue 9704044: Now that it works, make it nice. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger.cc
===================================================================
--- runtime/vm/debugger.cc (revision 5500)
+++ runtime/vm/debugger.cc (working copy)
@@ -22,7 +22,7 @@
namespace dart {
-static const bool verbose = true;
+static const bool verbose = false;
SourceBreakpoint::SourceBreakpoint(const Function& func, intptr_t token_index)
@@ -542,8 +542,7 @@
ASSERT(!code.IsNull());
PcDescriptors& desc = PcDescriptors::Handle(code.pc_descriptors());
intptr_t best_fit_index = -1;
- // TODO(hausner): find a symbolic value that works on all platforms.
- intptr_t best_fit = 0x7fffffff;
+ intptr_t best_fit = INT_MAX;
for (int i = 0; i < desc.Length(); i++) {
intptr_t desc_token_index = desc.TokenIndex(i);
if (desc_token_index < token_index) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698