Issue 9704039: Revert 126719 - IndexedDB: Fix prefetching; cache was always being bypassed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9704039: Revert 126719 - IndexedDB: Fix prefetching; cache was always being bypassed. (Closed)

Created:
8 years, 9 months ago by jsbell

Modified:
8 years, 9 months ago

Reviewers:
jsbell

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 126719 - IndexedDB: Fix prefetching; cache was always being bypassed. Regression introduced in r119183 when "Null" and "Invalid" were disambiguated. Tests will require refactoring; tracked as crbug.com/118033 BUG=117920 Review URL: http://codereview.chromium.org/9691021 TBR=jsbell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126752

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/common/indexed_db/proxy_webidbcursor_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jsbell

8 years, 9 months ago (2012-03-14 21:58:45 UTC) #2

FYI, this introduced a leak:

http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20UI%2...

Reverted (since memory trumps performance), will solve that before re-landing.

Expand Messages | Collapse Messages