Issue 9704029: Reland r126700: ash uber tray: Add the detailed network popup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9704029: Reland r126700: ash uber tray: Add the detailed network popup (Closed)

Created:
8 years, 9 months ago by sadrul

Modified:
8 years, 9 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, dhollowa+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Reland r126700: ash uber tray: Add the detailed network popup BUG=110130, 109480 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126738

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+493 lines, -21 lines)			Patch
M	ash/ash_strings.grd	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	ash/shell.cc	View		2 chunks	+16 lines, -1 line	0 comments	Download
M	ash/system/network/tray_network.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	ash/system/network/tray_network.cc	View		8 chunks	+276 lines, -5 lines	0 comments	Download
M	ash/system/tray/system_tray.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	ash/system/tray/system_tray.cc	View	1	2 chunks	+17 lines, -0 lines	0 comments	Download
M	ash/system/tray/system_tray_delegate.h	View	1 2 3	4 chunks	+25 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/system/ash_system_tray_delegate.cc	View		9 chunks	+131 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/browser.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View		2 chunks	+6 lines, -4 lines	0 comments	Download
M	ui/resources/ui_resources.grd	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sadrul

Hi! The original patch (http://codereview.chromium.org/9664056/) had to be reverted because it broke clang. Patchset1 here ...

8 years, 9 months ago (2012-03-14 20:12:25 UTC) #1

lgtm

Expand Messages | Collapse Messages