Replace URLRequestFailedDnsJob with URLRequestFailedJob

Modify URLRequestFailedDnsJob to allow any error code to be
returned while "connecting" to either an fake HTTP or HTTPS
server, and rename it to URLRequestFailedJob.

This is needed for testing the (unlanded) captive portal
detection/response code.

BUG=87100
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127488

[mmenke, 2012-03-15 14:52:59]

willchan: Please review everything.  If you have a suggestion for a better/less
busy reviewer for the mock request classes, that works, too, though this is a
pretty small and simple CL.

jam:  Please review content/*.  Can just rubber stamp content/test/net/.  I'd
add an OWNERs file, but not sure who to add, beyond Will and maybe wtc)

Thanks.

[jam, 2012-03-15 15:02:55]

On 2012/03/15 14:52:59, Matt Menke wrote:
> willchan: Please review everything.  If you have a suggestion for a
better/less
> busy reviewer for the mock request classes, that works, too, though this is a
> pretty small and simple CL.
> 
> jam:  Please review content/*.  Can just rubber stamp content/test/net/.  I'd
> add an OWNERs file, but not sure who to add, beyond Will and maybe wtc)

these files were all in content/browser/net and when I moved them I forgot to
move the OWNERS file. I've moved it in http://codereview.chromium.org/9708002/,
so if you can lgtm that one you won't need me here :)

[jam, 2012-03-15 15:03:26]

and content/browser and content_browser.gyp lgtm

[willchan no longer on Chromium, 2012-03-15 22:42:27]

http://codereview.chromium.org/9704023/diff/2010/chrome/browser/errorpage_bro...
File chrome/browser/errorpage_browsertest.cc (right):

http://codereview.chromium.org/9704023/diff/2010/chrome/browser/errorpage_bro...
chrome/browser/errorpage_browsertest.cc:76: GURL GetDnsErrorURL() {
Make the function const?

http://codereview.chromium.org/9704023/diff/2010/chrome/test/data/iframe_dns_...
File chrome/test/data/iframe_dns_error.html (right):

http://codereview.chromium.org/9704023/diff/2010/chrome/test/data/iframe_dns_...
chrome/test/data/iframe_dns_error.html:7: <iframe
src="http://mock.failed.request/-105"></iframe>
Can you add a comment indicating that this is a magic hostname defined by
URLRequestFailedJob.

http://codereview.chromium.org/9704023/diff/2010/content/test/net/url_request...
File content/test/net/url_request_failed_job.h (left):

http://codereview.chromium.org/9704023/diff/2010/content/test/net/url_request...
content/test/net/url_request_failed_job.h:35:
base::WeakPtrFactory<URLRequestFailedDnsJob> weak_factory_;
Why are we using SupportsWeakPtr instead of a WeakPtrFactory? I prefer not
having the public AsWeakPtr() method unless we need it.

[mmenke, 2012-03-15 22:55:45]

Thanks for the comments

http://codereview.chromium.org/9704023/diff/2010/chrome/browser/errorpage_bro...
File chrome/browser/errorpage_browsertest.cc (right):

http://codereview.chromium.org/9704023/diff/2010/chrome/browser/errorpage_bro...
chrome/browser/errorpage_browsertest.cc:76: GURL GetDnsErrorURL() {
On 2012/03/15 22:42:28, willchan wrote:
> Make the function const?

Done.

http://codereview.chromium.org/9704023/diff/2010/chrome/test/data/iframe_dns_...
File chrome/test/data/iframe_dns_error.html (right):

http://codereview.chromium.org/9704023/diff/2010/chrome/test/data/iframe_dns_...
chrome/test/data/iframe_dns_error.html:7: <iframe
src="http://mock.failed.request/-105"></iframe>
On 2012/03/15 22:42:28, willchan wrote:
> Can you add a comment indicating that this is a magic hostname defined by
> URLRequestFailedJob.

Done.

http://codereview.chromium.org/9704023/diff/2010/content/test/net/url_request...
File content/test/net/url_request_failed_job.h (left):

http://codereview.chromium.org/9704023/diff/2010/content/test/net/url_request...
content/test/net/url_request_failed_job.h:35:
base::WeakPtrFactory<URLRequestFailedDnsJob> weak_factory_;
On 2012/03/15 22:42:28, willchan wrote:
> Why are we using SupportsWeakPtr instead of a WeakPtrFactory? I prefer not
> having the public AsWeakPtr() method unless we need it.

Mostly because it's not publicly accessible anyways (Without casting, at least),
and I find "ALLOW_THIS_IN_INITIALIZER_LIST" hideous.

Switched back to using WeakPtrFactory.

[mmenke, 2012-03-19 15:00:39]

Will, could you sign off on this when you get a chance?  Thanks!

[willchan no longer on Chromium, 2012-03-19 15:20:01]

Lgtm
On Mar 19, 2012 8:00 AM, <mmenke@chromium.org> wrote:

> Will, could you sign off on this when you get a chance?  Thanks!
>
>
http://codereview.chromium.**org/9704023/<http://codereview.chromium.org/9704...
>

[commit-bot: I haz the power, 2012-03-19 15:22:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmenke@chromium.org/9704023/3033

[commit-bot: I haz the power, 2012-03-19 15:22:15]

Can't apply patch for file content/test/net/url_request_failed_job.cc.
While running patch -p0 --forward --force;
patching file content/test/net/url_request_failed_job.cc
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file
content/test/net/url_request_failed_job.cc.rej

[mmenke1, 2012-03-19 15:27:59]

On 2012/03/19 15:22:15, I haz the power (commit-bot) wrote:
> Can't apply patch for file content/test/net/url_request_failed_job.cc.
> While running patch -p0 --forward --force;
> patching file content/test/net/url_request_failed_job.cc
> Hunk #1 FAILED at 1.
> 1 out of 1 hunk FAILED -- saving rejects to file
> content/test/net/url_request_failed_job.cc.rej

Forgot the CQ hates moving files.  I'll run the trybots on a more recent build,
and then commit manually afterwards.