Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 9704020: remoting: convert another unittest MessageLoop to MessageLoopForIO (Closed)

Created:
8 years, 9 months ago by agl
Modified:
8 years, 9 months ago
Reviewers:
Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

remoting: convert another unittest MessageLoop to MessageLoopForIO r126562 was incomplete and I didn't notice, probably because my muscle memory builds Release by default and this only shows up in Debug builds. This is exactly r126562 again, but for a different test. TBR=wez BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126664

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M remoting/protocol/ssl_hmac_channel_authenticator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
agl
TBR because I had already landed a change in net/ which exposed this problem (although ...
8 years, 9 months ago (2012-03-14 17:03:36 UTC) #1
Wez
8 years, 9 months ago (2012-03-14 17:10:50 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698