net/test/base_test_server.h - Issue 9704008: Make the SpawnerCommunicator destructor virtual since it inherits from net::URLRequest::Delegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/test/base_test_server.h

Issue 9704008: Make the SpawnerCommunicator destructor virtual since it inherits from net::URLRequest::Delegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: make BaseTestServer's dtor virtual per chat w/ Ryan Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/test/base_test_server.h

===================================================================

--- net/test/base_test_server.h (revision 126537)

+++ net/test/base_test_server.h (working copy)

@@ -119,8 +119,6 @@

// Initialize a HTTPS TestServer with a specific set of HTTPSOptions.

explicit BaseTestServer(const HTTPSOptions& https_options);

- ~BaseTestServer();

// Returns the host port pair used by current Python based test server only

// if the server is started.

const HostPortPair& host_port_pair() const;

@@ -145,6 +143,7 @@

std::string* replacement_path);

protected:

+ virtual ~BaseTestServer();

Type type() const { return type_; }

// Gets port currently assigned to host_port_pair_ without checking

« no previous file with comments | « no previous file | net/test/local_test_server.h » ('j') | no next file with comments »