Make the SpawnerCommunicator destructor virtual since it inherits from net::URLRequest::Delegate

Make the SpawnerCommunicator destructor virtual since it inherits from net::URLRequest::Delegate
Also make BaseTestServer's dtor virtual protected to prevent the BaseTestServer pointer being directly deleted.

BUG=None
TEST=net_unittests should pass.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126865

[Ryan Sleevi, 2012-03-14 18:10:56]

You also need to update BaseTestServer, LocalTestServer, and RemoteTestServer.

[Johnny(Jianning) Ding, 2012-03-14 19:27:51]

done
On 2012/03/14 18:10:56, Ryan Sleevi wrote:
> You also need to update BaseTestServer, LocalTestServer, and RemoteTestServer.

[Ryan Sleevi, 2012-03-14 19:34:48]

lgtm

[commit-bot: I haz the power, 2012-03-14 19:39:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jnd@chromium.org/9704008/2003

[commit-bot: I haz the power, 2012-03-14 22:02:04]

Try job failure for 9704008-2003 (retry) on win_rel for step "browser_tests".
It's a second try, previously, steps "ui_tests, browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-03-14 22:11:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jnd@chromium.org/9704008/2003

[commit-bot: I haz the power, 2012-03-14 23:23:23]

Try job failure for 9704008-2003 (previous was lost) (retry) on linux_rel for
step "update".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-03-15 01:58:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jnd@chromium.org/9704008/2003

[commit-bot: I haz the power, 2012-03-15 04:44:34]

Try job failure for 9704008-2003 (previous was lost) (retry) on win for step
"compile" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...