Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 9703110: Revert dynamic frame alignment (r9415) (Closed)

Created:
8 years, 9 months ago by fschneider
Modified:
8 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Revert dynamic frame alignment (r9415) Marking aligned frames with a marker can produce false positives since an optimized frame spill slot may be mistakenly seen as a marker value. It also breaks the debugger reproducably: Tested when enabling alignment for all functions and running the debugger unit tests. BUG=v8:2009 TEST=no crashes in EarleyBoyer Committed: https://code.google.com/p/v8/source/detail?r=11075

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -117 lines) Patch
M src/deoptimizer.h View 2 chunks +0 lines, -9 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap.cc View 1 chunk +3 lines, -11 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 5 chunks +5 lines, -38 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 3 chunks +0 lines, -6 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 3 chunks +0 lines, -37 lines 0 comments Download
M src/ia32/lithium-ia32.h View 3 chunks +0 lines, -4 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
8 years, 9 months ago (2012-03-16 10:12:33 UTC) #1
Vyacheslav Egorov (Chromium)
8 years, 9 months ago (2012-03-16 11:59:10 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698