Issue 9703105: Re-land r5529.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9703105: Re-land r5529. (Closed)

Created:
8 years, 9 months ago by kasperl

Modified:
8 years, 9 months ago

Reviewers:
floitsch, ngeoffray

CC:
reviews_dartlang.org, floitsch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Re-land r5529. Update client-leg.status file. R=ngeoffray@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=5562

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+101 lines, -51 lines)			Patch
M	client/tests/client/client-leg.status	View	1 chunk	+3 lines, -6 lines	0 comments	Download
M	frog/leg/compile_time_constants.dart	View	3 chunks	+15 lines, -30 lines	0 comments	Download
M	frog/leg/resolver.dart	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	frog/leg/universe.dart	View	3 chunks	+7 lines, -6 lines	0 comments	Download
M	frog/leg/warnings.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/co19/co19-leg.status	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	tests/language/language-leg.status	View	2 chunks	+0 lines, -2 lines	0 comments	Download
A	tests/language/src/CompileTimeConstantETest.dart	View	1 chunk	+70 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

ngeoffray

LGTM, but IIRC, frog/frogium may also have had failures with the test in that CL.

8 years, 9 months ago (2012-03-16 09:17:39 UTC) #3

LGTM.
thanks for doing that.