Issue 9703078: ash: Highlight the items in the uber-tray popup when hovering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9703078: ash: Highlight the items in the uber-tray popup when hovering. (Closed)

Created:
8 years, 9 months ago by sadrul

Modified:
8 years, 9 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Highlight the items in the uber-tray popup when hovering. Since the items are already highlighted, remove underlining on hover for 'Settings' entry. BUG=118328 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126971

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Patch Set 3 : . #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -25 lines)			Patch
M	ash/system/settings/tray_settings.cc	View		1 chunk	+0 lines, -14 lines	0 comments	Download
M	ash/system/tray/system_tray.cc	View	1	4 chunks	+47 lines, -9 lines	0 comments	Download
M	ash/system/tray/tray_empty.cc	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	ash/system/user/tray_user.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

lgtm http://codereview.chromium.org/9703078/diff/1/ash/system/tray/system_tray.cc File ash/system/tray/system_tray.cc (right): http://codereview.chromium.org/9703078/diff/1/ash/system/tray/system_tray.cc#newcode72 ash/system/tray/system_tray.cc:72: virtual ~TrayItemContainer() {} put this below the ctor

8 years, 9 months ago (2012-03-15 19:05:40 UTC) #2

sadrul

8 years, 9 months ago (2012-03-15 19:11:08 UTC) #3

Thanks!

http://codereview.chromium.org/9703078/diff/1/ash/system/tray/system_tray.cc
File ash/system/tray/system_tray.cc (right):

http://codereview.chromium.org/9703078/diff/1/ash/system/tray/system_tray.cc#...
ash/system/tray/system_tray.cc:72: virtual ~TrayItemContainer() {}
On 2012/03/15 19:05:40, Ben Goodger (Google) wrote:
> put this below the ctor

Done.

Expand Messages | Collapse Messages