Issue 9703072: Enable tab sync on all platforms by default.

Issue 9703072: Enable tab sync on all platforms by default. (Closed)

Created:
8 years, 9 months ago by Patrick Dubroy

Modified:
8 years, 9 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, ncarter (slow), akalin, Raghu Simha, arv (Not doing code reviews), estade+watch_chromium.org, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable tab sync on all platforms by default. BUG=118572 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127510

Patch Set 2 : Remove NTP changes. #

Total comments: 2

Patch Set 3 : Fix comment & add TODO. #

Patch Set 4 : Fix broken unit tests. #

Patch Set 5 : Fix sync integration tests. #

Patch Set 6 : Disable TwoClientBookmarksSyncTest (per zea@) #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -10 lines)			Patch
M	chrome/browser/sync/glue/sync_backend_host.cc	View	1 2 3 4	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/sync/internal_api/sync_manager.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_components_factory_impl.cc	View	1 2 3	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/sync/test/integration/migration_errors_test.cc	View	1 2 3 4	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc	View	1 2 3 4 5	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Patrick Dubroy

Nicolas, can you please review? The idea (as discussed with Travis) is that all platforms ...

8 years, 9 months ago (2012-03-15 17:19:27 UTC) #1

Nicolas Zea

As I understand it, the plan is to revert this change on beta. So there's ...

8 years, 9 months ago (2012-03-15 17:58:52 UTC) #2

Patrick Dubroy

http://codereview.chromium.org/9703072/diff/1001/chrome/browser/sync/profile_sync_components_factory_impl.cc File chrome/browser/sync/profile_sync_components_factory_impl.cc (right): http://codereview.chromium.org/9703072/diff/1001/chrome/browser/sync/profile_sync_components_factory_impl.cc#newcode156 chrome/browser/sync/profile_sync_components_factory_impl.cc:156: // enable. Register only if explicitly enabled and not ...

8 years, 9 months ago (2012-03-16 09:01:28 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dubroy@chromium.org/9703072/4002

8 years, 9 months ago (2012-03-16 09:30:45 UTC) #5

commit-bot: I haz the power

Try job failure for 9703072-4002 (retry) on linux_rel for step "unit_tests". It's a second try, ...

8 years, 9 months ago (2012-03-16 10:16:36 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dubroy@chromium.org/9703072/4004

8 years, 9 months ago (2012-03-16 10:27:04 UTC) #7

commit-bot: I haz the power

8 years, 9 months ago (2012-03-16 11:26:51 UTC) #8

Try job failure for 9703072-4004 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages