Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 9703044: aura: fix hang when the content window is removed from the tree while a swap is pending (Closed)

Created:
8 years, 9 months ago by piman
Modified:
8 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

aura: fix hang when the content window is removed from the tree while a swap is pending BUG=118036 TEST=open 2 composited tabs that draw (e.g. flash video), quick swap between them with ctrl-tab, observe no hang. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126863

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -10 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 3 chunks +24 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
piman
8 years, 9 months ago (2012-03-15 00:05:46 UTC) #1
sky
LGTM https://chromiumcodereview.appspot.com/9703044/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc File content/browser/renderer_host/render_widget_host_view_aura.cc (right): https://chromiumcodereview.appspot.com/9703044/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc#newcode1129 content/browser/renderer_host/render_widget_host_view_aura.cc:1129: RunCompositingCallbacks(); Can you add a comment as to ...
8 years, 9 months ago (2012-03-15 00:30:41 UTC) #2
piman
https://chromiumcodereview.appspot.com/9703044/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc File content/browser/renderer_host/render_widget_host_view_aura.cc (right): https://chromiumcodereview.appspot.com/9703044/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc#newcode1129 content/browser/renderer_host/render_widget_host_view_aura.cc:1129: RunCompositingCallbacks(); On 2012/03/15 00:30:41, sky wrote: > Can you ...
8 years, 9 months ago (2012-03-15 00:38:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/9703044/1003
8 years, 9 months ago (2012-03-15 00:45:20 UTC) #4
commit-bot: I haz the power
Try job failure for 9703044-1003 (previous was lost) (retry) on win for step "compile" (clobber ...
8 years, 9 months ago (2012-03-15 04:15:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/9703044/1003
8 years, 9 months ago (2012-03-15 05:35:28 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-15 07:38:13 UTC) #7
Change committed as 126863

Powered by Google App Engine
This is Rietveld 408576698