Issue 9703043: disable WhitelistedExtension test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9703043: disable WhitelistedExtension test (Closed)

Created:
8 years, 9 months ago by scottmg

Modified:
8 years, 9 months ago

Reviewers:
mihaip, abarth-chromium

CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

disable WhitelistedExtension test TBR=abarth BUG=118293 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126789 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126821

Patch Set 1 #

Patch Set 2 : add bug number and disabled, not fails #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/extensions/all_urls_apitest.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mihaip_google.com

8 years, 9 months ago (2012-03-15 00:13:31 UTC) #2

Can you leave a comment with the bug number next to the FAILS_ line? Also,
it's generally preferred to only disable tests on the platforms that it
actually fails on (via a #if defined(ADDRESS_SANITIZER)
|| defined(OS_MACOSX) check).

Mihai

On Wed, Mar 14, 2012 at 4:47 PM, <scottmg@chromium.org> wrote:

> Reviewers: abarth,
>
> Description:
> disable WhitelistedExtension test
>
> TBR=abarth
> BUG=118293
>
>
> Please review this at
https://chromiumcodereview.**appspot.com/9703043/<https://chromiumcodereview....
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/browser/extensions/all_**urls_apitest.cc
>
>
> Index: chrome/browser/extensions/all_**urls_apitest.cc
> diff --git a/chrome/browser/extensions/**all_urls_apitest.cc
> b/chrome/browser/extensions/**all_urls_apitest.cc
> index cf353ce4d5378b2d02709114e671b6**1c0e2451fa..**
> f30a038717cf2c3a14f613f909ac00**6d693963ab 100644
> --- a/chrome/browser/extensions/**all_urls_apitest.cc
> +++ b/chrome/browser/extensions/**all_urls_apitest.cc
> @@ -15,7 +15,7 @@ const std::string kAllUrlsTarget =
>
>  typedef ExtensionApiTest AllUrlsApiTest;
>
> -IN_PROC_BROWSER_TEST_F(**AllUrlsApiTest, WhitelistedExtension) {
> +IN_PROC_BROWSER_TEST_F(**AllUrlsApiTest, FAILS_WhitelistedExtension) {
>   // First setup the two extensions.
>   FilePath extension_dir1 = test_data_dir_.AppendASCII("**all_urls")
>                                           .AppendASCII("content_script")**
> ;
>
>
>

Expand Messages | Collapse Messages