Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6955)

Unified Diff: chrome/browser/plugin_prefs_factory.h

Issue 9703038: Profiles: Really fix refcounted services. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Forgot to save a file. >_< Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/plugin_prefs.cc ('k') | chrome/browser/plugin_prefs_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/plugin_prefs_factory.h
diff --git a/chrome/browser/plugin_prefs_factory.h b/chrome/browser/plugin_prefs_factory.h
index e29dd9d1782782921c29f464597c9f506cee91bd..c45d9d1db709396048f9fd01af6e62f8151e4754 100644
--- a/chrome/browser/plugin_prefs_factory.h
+++ b/chrome/browser/plugin_prefs_factory.h
@@ -17,20 +17,23 @@ class ProfileKeyedService;
class PluginPrefsFactory : public RefcountedProfileKeyedServiceFactory {
public:
- static PluginPrefsFactory* GetInstance();
-
- PluginPrefs* GetPrefsForProfile(Profile* profile);
+ static scoped_refptr<PluginPrefs> GetPrefsForProfile(Profile* profile);
- static ProfileKeyedBase* CreatePrefsForProfile(Profile* profile);
+ static PluginPrefsFactory* GetInstance();
private:
+ friend class PluginPrefs;
friend struct DefaultSingletonTraits<PluginPrefsFactory>;
+ // Helper method for PluginPrefs::GetForTestingProfile.
+ static scoped_refptr<RefcountedProfileKeyedService> CreateForTestingProfile(
+ Profile* profile);
+
PluginPrefsFactory();
virtual ~PluginPrefsFactory();
// RefcountedProfileKeyedServiceFactory methods:
- virtual RefcountedProfileKeyedService* BuildServiceInstanceFor(
+ virtual scoped_refptr<RefcountedProfileKeyedService> BuildServiceInstanceFor(
Profile* profile) const OVERRIDE;
// ProfileKeyedServiceFactory methods:
« no previous file with comments | « chrome/browser/plugin_prefs.cc ('k') | chrome/browser/plugin_prefs_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698