Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 9703036: Refresh action for the Files View. (Closed)

Created:
8 years, 9 months ago by pquitslund
Modified:
8 years, 9 months ago
Reviewers:
devoncarew, danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -4 lines) Patch
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/filesview/FilesView.java View 5 chunks +16 lines, -4 lines 0 comments Download
A editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/filesview/RefreshAction.java View 1 chunk +98 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pquitslund
8 years, 9 months ago (2012-03-14 20:00:45 UTC) #1
danrubel
LGTM. Does it also belong in the Files menu?
8 years, 9 months ago (2012-03-14 20:19:22 UTC) #2
devoncarew
lgtm Looks good! My druthers would be for a key binding for refresh as well.
8 years, 9 months ago (2012-03-14 21:50:14 UTC) #3
pquitslund
8 years, 9 months ago (2012-03-14 22:11:07 UTC) #4
Thanks for the reviews!

The menu item and keybinding refinements will require a little doing so I broke
them into a separate follow-on request:
http://code.google.com/p/dart/issues/detail?id=2173

Powered by Google App Engine
This is Rietveld 408576698