Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Issue 9703034: ash/wm: Use gfx::Canvas::FillRect to draw the separator line instead of relying in DrawLine. (Closed)

Created:
8 years, 9 months ago by tfarina
Modified:
8 years, 9 months ago
Reviewers:
Peter Kasting, sky
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

ash/wm: Use gfx::Canvas::FillRect to draw the separator line instead of relying in DrawLine. BUG=100898 R=pkasting@chromium.org,sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126774

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Peter review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M ash/wm/panel_frame_view.cc View 1 3 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
Peter: main reviewer. Scott: for OWNER approval.
8 years, 9 months ago (2012-03-14 19:56:33 UTC) #1
Peter Kasting
http://codereview.chromium.org/9703034/diff/3001/ash/wm/panel_frame_view.cc File ash/wm/panel_frame_view.cc (right): http://codereview.chromium.org/9703034/diff/3001/ash/wm/panel_frame_view.cc#newcode96 ash/wm/panel_frame_view.cc:96: bounds.bottom()), kCaptionIconDivisorColor); Shouldn't this be bounds.height()? Actually a cleaner ...
8 years, 9 months ago (2012-03-14 20:23:08 UTC) #2
tfarina
http://codereview.chromium.org/9703034/diff/3001/ash/wm/panel_frame_view.cc File ash/wm/panel_frame_view.cc (right): http://codereview.chromium.org/9703034/diff/3001/ash/wm/panel_frame_view.cc#newcode96 ash/wm/panel_frame_view.cc:96: bounds.bottom()), kCaptionIconDivisorColor); On 2012/03/14 20:23:09, Peter Kasting wrote: > ...
8 years, 9 months ago (2012-03-14 20:36:37 UTC) #3
Peter Kasting
LGTM
8 years, 9 months ago (2012-03-14 20:39:03 UTC) #4
sky
8 years, 9 months ago (2012-03-14 21:20:41 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698