Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 9703031: Retry landing "Enable users change desktop background image from settings page in Chromeos Aura bui… (Closed)

Created:
8 years, 9 months ago by bshe
Modified:
8 years, 9 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, dhollowa+watch_chromium.org, arv (Not doing code reviews), stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Retry landing "Enable users change desktop background image from settings page in Chromeos Aura build" Enable user change background image in settings page in Aura build. Only support change between default background images currently. This is a second try to land, last time it fails on win_aura build. The original CL is here: http://codereview.chromium.org/9580023/ TBR=flackr,ben,jhawkins BUG=105508 TEST=Go to settings page and click "set wallpaper" button to change background image. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126923

Patch Set 1 #

Patch Set 2 : Fix for win_aura builds #

Patch Set 3 : Merge to trunk #

Patch Set 4 : Fix setting test fail #

Patch Set 5 : Merge to trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+848 lines, -114 lines) Patch
M ash/accelerators/accelerator_controller.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M ash/ash.gyp View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
A ash/desktop_background/desktop_background_controller.h View 1 chunk +66 lines, -0 lines 0 comments Download
A ash/desktop_background/desktop_background_controller.cc View 1 chunk +77 lines, -0 lines 0 comments Download
A ash/desktop_background/desktop_background_resources.h View 1 chunk +19 lines, -0 lines 0 comments Download
A ash/desktop_background/desktop_background_resources.cc View 1 chunk +67 lines, -0 lines 0 comments Download
M ash/desktop_background/desktop_background_view.h View 2 chunks +7 lines, -2 lines 0 comments Download
M ash/desktop_background/desktop_background_view.cc View 2 chunks +10 lines, -5 lines 0 comments Download
M ash/shell.h View 1 2 3 4 8 chunks +8 lines, -13 lines 0 comments Download
M ash/shell.cc View 1 2 3 4 5 chunks +7 lines, -23 lines 0 comments Download
M ash/shell_factory.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/background/desktop_background_observer.h View 1 chunk +36 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/background/desktop_background_observer.cc View 1 chunk +50 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/mock_user_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager.h View 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 3 chunks +32 lines, -0 lines 0 comments Download
M chrome/browser/resources/options2/browser_options.html View 1 2 3 4 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/resources/options2/browser_options.js View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
D chrome/browser/resources/options2/chromeos/change_picture_options.css View 1 chunk +0 lines, -37 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/change_picture_options.html View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/resources/options2/chromeos/image_picker.css View 3 chunks +5 lines, -5 lines 0 comments Download
A chrome/browser/resources/options2/chromeos/set_wallpaper_options.css View 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/browser/resources/options2/chromeos/set_wallpaper_options.html View 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/browser/resources/options2/chromeos/set_wallpaper_options.js View 1 chunk +137 lines, -0 lines 0 comments Download
M chrome/browser/resources/options2/options.html View 1 2 3 4 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/resources/options2/options.js View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/resources/options2/options_bundle.js View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options2/browser_options_handler2.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/options2/chromeos/set_wallpaper_options_handler2.h View 1 chunk +57 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/options2/chromeos/set_wallpaper_options_handler2.cc View 1 chunk +116 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options2/options_ui2.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M ui/resources/ui_resources.grd View 1 2 1 chunk +19 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
bshe
This CL retries to land http://codereview.chromium.org/9580023/ It was reverted because of a win_aura problem. The ...
8 years, 9 months ago (2012-03-14 20:31:50 UTC) #1
James Hawkins
8 years, 9 months ago (2012-03-14 20:33:09 UTC) #2
Please run the entire set of try jobs.

Powered by Google App Engine
This is Rietveld 408576698