Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Side by Side Diff: runtime/bin/process_impl.dart

Issue 9703023: Fix some minor static type issues in dart:io implementation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 class _ProcessStartStatus { 5 class _ProcessStartStatus {
6 int _errorCode; // Set to OS error code if process start failed. 6 int _errorCode; // Set to OS error code if process start failed.
7 String _errorMessage; // Set to OS error message if process start failed. 7 String _errorMessage; // Set to OS error message if process start failed.
8 } 8 }
9 9
10 10
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 _onError = callback; 190 _onError = callback;
191 } 191 }
192 192
193 void set onStart(void callback()) { 193 void set onStart(void callback()) {
194 _onStart = callback; 194 _onStart = callback;
195 } 195 }
196 196
197 String _path; 197 String _path;
198 ObjectArray<String> _arguments; 198 ObjectArray<String> _arguments;
199 String _workingDirectory; 199 String _workingDirectory;
200 Socket _in; 200 // Private methods of _Socket are used by _in, _out, and _err.
201 Socket _out; 201 _Socket _in;
202 Socket _err; 202 _Socket _out;
203 _Socket _err;
203 Socket _exitHandler; 204 Socket _exitHandler;
204 int _pid; 205 int _pid;
205 bool _closed; 206 bool _closed;
206 bool _killed; 207 bool _killed;
207 bool _started; 208 bool _started;
208 Function _onExit; 209 Function _onExit;
209 Function _onError; 210 Function _onError;
210 Function _onStart; 211 Function _onStart;
211 } 212 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698