Printing: Catch more error conditions and remove more cruft.

chrome/renderer/print_web_view_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/print_web_view_helper.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 986 matching lines @@
 
 void PrintWebViewHelper::Print(WebKit::WebFrame* frame,
                                const WebKit::WebNode& node) {
   // If still not finished with earlier print request simply ignore.
   if (print_web_view_)
     return;
 
   // Initialize print settings.
   scoped_ptr<PrepareFrameAndViewForPrint> prepare;
   if (!InitPrintSettingsAndPrepareFrame(frame, node, &prepare)) {
-    DidFinishPrinting(FAIL_PRINT);
+    DidFinishPrinting(FAIL_PRINT_INIT);

[Lei Zhang, 2012/03/14 05:40:05]

InitPrintSettingsAndPrepareFrame() already displays its own error dialog. If we
return FAIL_PRINT here, we'll display a second one in DidFinishPrinting().

     return;  // Failed to init print page settings.
   }
 
   int expected_page_count = 0;
   bool use_browser_overlays = true;
 
   expected_page_count = prepare->GetExpectedPageCount();
   if (expected_page_count)
     use_browser_overlays = prepare->ShouldUseBrowserOverlays();
 
@@ skipping 17 matching lines @@
   // Render Pages for printing.
   if (!RenderPagesForPrint(frame, node)) {
     LOG(ERROR) << "RenderPagesForPrint failed";
     DidFinishPrinting(FAIL_PRINT);
   }
   ResetScriptedPrintCount();
 }
 
 void PrintWebViewHelper::DidFinishPrinting(PrintingResult result) {
   bool store_print_pages_params = true;
-  if (result == FAIL_PRINT) {
-    DisplayPrintJobError();
+  switch (result) {
+    case OK:
+      break;
 
-    if (notify_browser_of_print_failure_ && print_pages_params_.get()) {
-      int cookie = print_pages_params_->params.document_cookie;
-      Send(new PrintHostMsg_PrintingFailed(routing_id(), cookie));
-    }
-  } else if (result == FAIL_PREVIEW) {
-    DCHECK(is_preview_enabled_);
-    store_print_pages_params = false;
-    int cookie = print_pages_params_.get() ?
-                     print_pages_params_->params.document_cookie : 0;
-    if (notify_browser_of_print_failure_)
-      Send(new PrintHostMsg_PrintPreviewFailed(routing_id(), cookie));
-    else
-      Send(new PrintHostMsg_PrintPreviewCancelled(routing_id(), cookie));
-    print_preview_context_.Failed(notify_browser_of_print_failure_);
+    case FAIL_PRINT_INIT:
+      DCHECK(!notify_browser_of_print_failure_);
+      break;
+
+    case FAIL_PRINT:
+      DisplayPrintJobError();
+
+      if (notify_browser_of_print_failure_ && print_pages_params_.get()) {
+        int cookie = print_pages_params_->params.document_cookie;
+        Send(new PrintHostMsg_PrintingFailed(routing_id(), cookie));
+      }
+      break;
+
+    case FAIL_PREVIEW:
+      DCHECK(is_preview_enabled_);
+      store_print_pages_params = false;
+      int cookie = print_pages_params_.get() ?
+          print_pages_params_->params.document_cookie : 0;
+      if (notify_browser_of_print_failure_)
+        Send(new PrintHostMsg_PrintPreviewFailed(routing_id(), cookie));
+      else
+        Send(new PrintHostMsg_PrintPreviewCancelled(routing_id(), cookie));
+      print_preview_context_.Failed(notify_browser_of_print_failure_);
   }
 
   if (print_web_view_) {
     print_web_view_->close();
     print_web_view_ = NULL;
   }
 
   if (store_print_pages_params) {
     old_print_pages_params_.reset(print_pages_params_.release());
   } else {
@@ skipping 96 matching lines @@
     bool ignore_css_margins,
     bool fit_to_page) {
   if (PrintingNodeOrPdfFrame(frame, node))
     return;
   PrintMsg_Print_Params print_params = CalculatePrintParamsForCss(
       frame, 0, params, ignore_css_margins, ignore_css_margins && fit_to_page,
       NULL);
   prepare->UpdatePrintParams(print_params);
 }
 
-bool PrintWebViewHelper::InitPrintSettings(WebKit::WebFrame* frame,
-                                           const WebKit::WebNode& node) {
-  DCHECK(frame);
+bool PrintWebViewHelper::InitPrintSettings() {
   PrintMsg_PrintPages_Params settings;
-
-  // Reset to default values.
-  ignore_css_margins_ = false;
-  fit_to_page_ = true;
-
   Send(new PrintHostMsg_GetDefaultPrintSettings(routing_id(),
                                                 &settings.params));
   // Check if the printer returned any settings, if the settings is empty, we
   // can safely assume there are no printer drivers configured. So we safely
   // terminate.
   bool result = true;
-  if (PrintMsg_Print_Params_IsEmpty(settings.params)) {
-    render_view()->RunModalAlertDialog(
-        frame,
-        l10n_util::GetStringUTF16(
-            IDS_PRINT_PREVIEW_INVALID_PRINTER_SETTINGS));
+  if (PrintMsg_Print_Params_IsEmpty(settings.params))
     result = false;
-  }
 
   if (result &&
       (settings.params.dpi < kMinDpi || settings.params.document_cookie == 0)) {
     // Invalid print page settings.
     NOTREACHED();
     result = false;
   }
 
+  // Reset to default values.
+  ignore_css_margins_ = false;
+  fit_to_page_ = true;
   settings.pages.clear();
+
   print_pages_params_.reset(new PrintMsg_PrintPages_Params(settings));
   return result;
 }
 
 bool PrintWebViewHelper::InitPrintSettingsAndPrepareFrame(
     WebKit::WebFrame* frame, const WebKit::WebNode& node,
     scoped_ptr<PrepareFrameAndViewForPrint>* prepare) {
-  if (!InitPrintSettings(frame, node))
+  DCHECK(frame);
+  if (!InitPrintSettings()) {
+    notify_browser_of_print_failure_ = false;
+    render_view()->RunModalAlertDialog(
+        frame,
+        l10n_util::GetStringUTF16(IDS_PRINT_PREVIEW_INVALID_PRINTER_SETTINGS));
     return false;
+  }
 
   DCHECK(!prepare->get());
   prepare->reset(new PrepareFrameAndViewForPrint(print_pages_params_->params,
                                                  frame, node));
   UpdateFrameAndViewFromCssPageLayout(frame, node, prepare->get(),
                                       print_pages_params_->params,
                                       ignore_css_margins_, fit_to_page_);
   Send(new PrintHostMsg_DidGetDocumentCookie(
         routing_id(), print_pages_params_->params.document_cookie));
   return true;
@@ skipping 538 matching lines @@
   DCHECK(IsRendering());
   return prep_frame_view_->GetPrintCanvasSize();
 }
 
 void PrintWebViewHelper::PrintPreviewContext::ClearContext() {
   prep_frame_view_.reset();
   metafile_.reset();
   pages_to_render_.clear();
   error_ = PREVIEW_ERROR_NONE;
 }