Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3845)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 9703004: Revert change 5444 (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/language/src/ParameterInitializerTest.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
===================================================================
--- tools/testing/dart/test_runner.dart (revision 5447)
+++ tools/testing/dart/test_runner.dart (working copy)
@@ -186,13 +186,13 @@
bool get hasTimedOut();
bool get didFail();
-
+
Duration get time();
-
+
List<String> get stdout();
List<String> get stderr();
-
+
List<String> get diagnostics();
}
@@ -353,7 +353,7 @@
Expect.isNotNull(outcome);
if (outcome.contains('compile-time error') && errors.length > 0) {
return true;
- } else if (outcome.contains('static type warning')
+ } else if (outcome.contains('static type warning')
&& staticWarnings.length > 0) {
return true;
} else if (outcome.isEmpty()
@@ -498,7 +498,7 @@
for (var line in testCase.output.stderr) print(line);
for (var line in testCase.output.stdout) print(line);
}
- if (allowRetries && testCase.usesWebDriver
+ if (allowRetries && testCase.usesWebDriver
&& testCase.output.unexpectedOutput && testCase.numRetries > 0) {
// Selenium tests can be flaky. Try rerunning.
testCase.output.requestRetry = true;
@@ -840,13 +840,10 @@
Date startTime,
bool printTiming,
Function this._enqueueMoreWork,
- [bool verbose = false,
- bool listTests = false,
- bool keepGeneratedTests = false])
- : _verbose = verbose,
- _listTests = listTests,
- _keepGeneratedTests = keepGeneratedTests,
- _tests = new Queue<TestCase>(),
+ [bool this._verbose = false,
+ bool this._listTests = false,
+ bool this._keepGeneratedTests = false])
+ : _tests = new Queue<TestCase>(),
_progress = new ProgressIndicator.fromName(progress,
startTime,
printTiming),
« no previous file with comments | « tests/language/src/ParameterInitializerTest.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698