Issue 9702103: Clean up first run:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9702103: Clean up first run: (Closed)

Created:
8 years, 9 months ago by Peter Kasting

Modified:
8 years, 9 months ago

Reviewers:
jennyz

CC:
chromium-reviews, tfarina

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Clean up first run: * Replace the idea of a FirstRunBrowserProcess, which existed solely to prevent a couple of classes from trying to make network connections, with passing the "disable background networking" switch to the relevant process. * Eliminate a bunch of unused machinery to try and parent the import progress window. This was always just parented to NULL. * A few other small cleanups in first_run_win.cc. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127230

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -159 lines)			Patch
M	chrome/browser/chrome_browser_main.cc	View	2 chunks	+6 lines, -14 lines	0 comments	Download
M	chrome/browser/first_run/first_run.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
D	chrome/browser/first_run/first_run_browser_process.h	View	1 chunk	+0 lines, -29 lines	0 comments	Download
D	chrome/browser/first_run/first_run_browser_process.cc	View	1 chunk	+0 lines, -22 lines	0 comments	Download
M	chrome/browser/first_run/first_run_linux.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/first_run/first_run_win.cc	View	5 chunks	+24 lines, -38 lines	0 comments	Download
M	chrome/browser/importer/importer_progress_dialog.h	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/cocoa/importer/import_progress_dialog_cocoa.mm	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/importer/import_progress_dialog_gtk.h	View	3 chunks	+2 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/gtk/importer/import_progress_dialog_gtk.cc	View	4 chunks	+7 lines, -16 lines	0 comments	Download
M	chrome/browser/ui/views/importer/import_progress_dialog_view.h	View	3 chunks	+1 line, -6 lines	0 comments	Download
M	chrome/browser/ui/views/importer/import_progress_dialog_view.cc	View	5 chunks	+4 lines, -14 lines	0 comments	Download
M	chrome/browser/ui/views/stubs_aura.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages