content/common/gpu/gpu_command_buffer_stub.cc - Issue 9702081: Splitting GpuMemoryAllocation into two parts: for renderer and browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/gpu_command_buffer_stub.cc

Issue 9702081: Splitting GpuMemoryAllocation into two parts: for renderer and browser (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Adding unittests for GpuMemoryAllocation comparison functions since they have become not as trivial. Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/gpu_command_buffer_stub.cc

diff --git a/content/common/gpu/gpu_command_buffer_stub.cc b/content/common/gpu/gpu_command_buffer_stub.cc

index 96ca0ea68ab85ff030ddaac2a1a4a1494614602e..f277eca2fc88ff84c1fe1e7e190cbf5de8d379fc 100644

--- a/content/common/gpu/gpu_command_buffer_stub.cc

+++ b/content/common/gpu/gpu_command_buffer_stub.cc

@@ -623,12 +623,14 @@ void GpuCommandBufferStub::SetMemoryAllocation(

SendMemoryAllocationToProxy(allocation);

+ DCHECK(surface_);

if (!surface_)

return;

- if (allocation.has_frontbuffer && allocation.has_backbuffer)

+ if (allocation.suggest_have_frontbuffer && allocation.suggest_have_backbuffer)

surface_->SetBufferAllocation(

gfx::GLSurface::BUFFER_ALLOCATION_FRONT_AND_BACK);

- else if (allocation.has_frontbuffer)

+ else if (allocation.suggest_have_frontbuffer)

surface_->SetBufferAllocation(

gfx::GLSurface::BUFFER_ALLOCATION_FRONT_ONLY);

else