Splitting GpuMemoryAllocation into two parts: for renderer and browser

content/common/gpu/gpu_messages.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included message file, hence no include guard here, but see below
 // for a much smaller-than-usual include guard section.
 
 #include <vector>
 #include <string>
 
@@ skipping 101 matching lines @@
   IPC_STRUCT_TRAITS_MEMBER(gl_renderer)
   IPC_STRUCT_TRAITS_MEMBER(gl_extensions)
   IPC_STRUCT_TRAITS_MEMBER(can_lose_context)
   IPC_STRUCT_TRAITS_MEMBER(performance_stats)
   IPC_STRUCT_TRAITS_MEMBER(software_rendering)
 #if defined(OS_WIN)
   IPC_STRUCT_TRAITS_MEMBER(dx_diagnostics)
 #endif
 IPC_STRUCT_TRAITS_END()
 
-IPC_STRUCT_TRAITS_BEGIN(GpuMemoryAllocation)
+IPC_STRUCT_TRAITS_BEGIN(GpuMemoryAllocationForRenderer)
   IPC_STRUCT_TRAITS_MEMBER(gpu_resource_size_in_bytes)
-  IPC_STRUCT_TRAITS_MEMBER(has_frontbuffer)
-  IPC_STRUCT_TRAITS_MEMBER(has_backbuffer)
+  IPC_STRUCT_TRAITS_MEMBER(suggest_have_backbuffer)
 IPC_STRUCT_TRAITS_END()
 
 IPC_STRUCT_TRAITS_BEGIN(gfx::GLSurfaceHandle)
   IPC_STRUCT_TRAITS_MEMBER(handle)
   IPC_STRUCT_TRAITS_MEMBER(transport)
   IPC_STRUCT_TRAITS_MEMBER(parent_gpu_process_id)
   IPC_STRUCT_TRAITS_MEMBER(parent_client_id)
   IPC_STRUCT_TRAITS_MEMBER(parent_context_id)
   IPC_STRUCT_TRAITS_MEMBER(parent_texture_id[0])
   IPC_STRUCT_TRAITS_MEMBER(parent_texture_id[1])
@@ skipping 298 matching lines @@
 // delayed.
 IPC_MESSAGE_ROUTED1(GpuCommandBufferMsg_Echo,
                     IPC::Message /* reply */)
 
 // Response to a GpuChannelMsg_Echo message.
 IPC_MESSAGE_ROUTED0(GpuCommandBufferMsg_EchoAck)
 
 // Send to stub on surface visibility change.
 IPC_MESSAGE_ROUTED1(GpuCommandBufferMsg_SetSurfaceVisible, bool /* visible */)
 
+// Request that the GPU process create/destroy the surface backbuffer.
+IPC_MESSAGE_ROUTED0(GpuCommandBufferMsg_CreateBackbuffer)

[piman, 2012/03/15 20:14:32]

Doing these as commands into the command buffer (like SetVisibility is done now)
would make it easier to track state in the GLES2CmdDecoder, as to either
generate errors in case of misuse or to implicitly recreate the back buffer on
draw/clear/readback commands.

Similarly, client-side, making it go through the GLES2Implementation would let
you add asserts.

[mmocny, 2012/03/15 20:39:27]

Okay, I was undecided here, and I think you are correct.  It may make it harder
for me to temporarily hook dropping frontbuffers onto dropping backbuffers, but
that needs decoupling anyway.

On 2012/03/15 20:14:32, piman wrote:

+IPC_MESSAGE_ROUTED0(GpuCommandBufferMsg_DestroyBackbuffer)
+
 // Sent to proxy when the gpu memory manager changes its memory allocation.
 IPC_MESSAGE_ROUTED1(GpuCommandBufferMsg_SetMemoryAllocation,
-                    GpuMemoryAllocation /* allocation */)
+                    GpuMemoryAllocationForRenderer /* allocation */)
 
 //------------------------------------------------------------------------------
 // Accelerated Video Decoder Messages
 // These messages are sent from Renderer process to GPU process.
 
 // Send input buffer for decoding.
 IPC_MESSAGE_ROUTED3(AcceleratedVideoDecoderMsg_Decode,
                     base::SharedMemoryHandle, /* input_buffer_handle */
                     int32, /* bitstream_buffer_id */
                     int32) /* size */
@@ skipping 46 matching lines @@
 
 // Confirm decoder has been flushed.
 IPC_MESSAGE_ROUTED0(AcceleratedVideoDecoderHostMsg_FlushDone)
 
 // Confirm decoder has been reset.
 IPC_MESSAGE_ROUTED0(AcceleratedVideoDecoderHostMsg_ResetDone)
 
 // Video decoder has encountered an error.
 IPC_MESSAGE_ROUTED1(AcceleratedVideoDecoderHostMsg_ErrorNotification,
                     uint32) /* Error ID */