Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 9702076: bluetooth: guard adapter_ in destructor (Closed)

Created:
8 years, 9 months ago by keybuk
Modified:
8 years, 9 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews
Visibility:
Public.

Description

bluetooth: guard adapter_ in destructor Since we don't set adapter_ early, it's possible for the destructor to be called without it ever being initialized. Guard that call. BUG=none TEST=emerge chromeos-chrome Change-Id: I64724c3bf7272b9d5588713872627462ebcbe878 R=jhawkins@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126946

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/webui/options2/chromeos/bluetooth_options_handler2.cc View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 6 (0 generated)
keybuk
8 years, 9 months ago (2012-03-15 16:28:14 UTC) #1
James Hawkins
https://chromiumcodereview.appspot.com/9702076/diff/1/chrome/browser/ui/webui/options2/chromeos/bluetooth_options_handler2.cc File chrome/browser/ui/webui/options2/chromeos/bluetooth_options_handler2.cc (right): https://chromiumcodereview.appspot.com/9702076/diff/1/chrome/browser/ui/webui/options2/chromeos/bluetooth_options_handler2.cc#newcode62 chrome/browser/ui/webui/options2/chromeos/bluetooth_options_handler2.cc:62: if (adapter_.get()) Optional nit: You can leave off the ...
8 years, 9 months ago (2012-03-15 17:19:06 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 9 months ago (2012-03-15 17:22:59 UTC) #3
James Hawkins
Sorry, LGTM
8 years, 9 months ago (2012-03-15 17:24:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/9702076/1
8 years, 9 months ago (2012-03-15 17:30:16 UTC) #5
keybuk
8 years, 9 months ago (2012-03-15 17:30:32 UTC) #6
:) I'm going to keep the .get() there, because it matches the rest of the code
which uses it - internal consistency and all that

(and I can never remember which of scoped_refptr<> scoped_ptr<> etc. need get
vs. don't)

Powered by Google App Engine
This is Rietveld 408576698