Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 9702051: Fix typo in options2 browser_options.js (Closed)

Created:
8 years, 9 months ago by kochi
Modified:
8 years, 9 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews), Andrew T Wilson (Slow)
Visibility:
Public.

Description

Fix typo in options2 browser_options.js This will properly disable "Disconnect my account..." button on ChromeOS. cr.isChromeOs (note the last small "s", not capital "S") returned "undefined" and thus "Disconnect..." button's hidden attribute was always false (i.e. visible on ChromeOS). BUG=116342 TEST=manually open chrome://settings with signed-in account and see "Disconnect your google account" button won't appear. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126842

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/options2/browser_options.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
kochi
Hi James, Could you review this?
8 years, 9 months ago (2012-03-14 23:49:51 UTC) #1
James Hawkins
lgtm
8 years, 9 months ago (2012-03-14 23:51:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/9702051/1
8 years, 9 months ago (2012-03-14 23:56:40 UTC) #3
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
8 years, 9 months ago (2012-03-15 02:53:41 UTC) #4
commit-bot: I haz the power
8 years, 9 months ago (2012-03-15 03:41:02 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698