Issue 9702037: ash: Clean up some uber-tray related code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9702037: ash: Clean up some uber-tray related code. (Closed)

Created:
8 years, 9 months ago by sadrul

Modified:
8 years, 9 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, dhollowa+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Clean up some uber-tray related code. Rename the various 'Controller's to 'Observer's, because that makes more sense, and move these observers from Shell into SystemTray. BUG=110130 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126758

Patch Set 1 : . #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+111 lines, -213 lines)			Patch
M	ash/ash.gyp	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	ash/shell.h	View	3 chunks	+0 lines, -32 lines	0 comments	Download
M	ash/shell.cc	View	3 chunks	+7 lines, -13 lines	0 comments	Download
D	ash/system/audio/audio_controller.h	View	1 chunk	+0 lines, -21 lines	0 comments	Download
A +	ash/system/audio/audio_observer.h	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	ash/system/audio/tray_volume.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
D	ash/system/brightness/brightness_controller.h	View	1 chunk	+0 lines, -21 lines	0 comments	Download
A +	ash/system/brightness/brightness_observer.h	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	ash/system/brightness/tray_brightness.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
D	ash/system/network/network_controller.h	View	1 chunk	+0 lines, -22 lines	0 comments	Download
A +	ash/system/network/network_observer.h	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	ash/system/network/tray_network.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
D	ash/system/power/power_status_controller.h	View	1 chunk	+0 lines, -21 lines	0 comments	Download
A +	ash/system/power/power_status_observer.h	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	ash/system/power/tray_power_date.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	ash/system/tray/system_tray.h	View	3 chunks	+36 lines, -0 lines	0 comments	Download
M	ash/system/tray/system_tray.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	ash/system/user/tray_user.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
D	ash/system/user/update_controller.h	View	1 chunk	+0 lines, -21 lines	0 comments	Download
A +	ash/system/user/update_observer.h	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/system/ash_system_tray_delegate.cc	View	4 chunks	+17 lines, -17 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages