Issue 9702035: Revert 126700 because it broke clang on chromeos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9702035: Revert 126700 because it broke clang on chromeos. (Closed)

Created:
8 years, 9 months ago by sadrul

Modified:
8 years, 9 months ago

Reviewers:
sadrul

CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, dhollowa+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 126700 because it broke clang on chromeos. --- ash uber tray: Add the detailed network popup BUG=110130, 109480 TEST=none Review URL: https://chromiumcodereview.appspot.com/9664056 TBR=sadrul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126706

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -482 lines)			Patch
M	ash/ash_strings.grd	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	ash/shell.cc	View	2 chunks	+1 line, -16 lines	0 comments	Download
M	ash/system/network/tray_network.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	ash/system/network/tray_network.cc	View	8 chunks	+5 lines, -276 lines	0 comments	Download
M	ash/system/tray/system_tray.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	ash/system/tray/system_tray.cc	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	ash/system/tray/system_tray_delegate.h	View	4 chunks	+1 line, -20 lines	0 comments	Download
M	chrome/browser/chromeos/system/ash_system_tray_delegate.cc	View	9 chunks	+7 lines, -131 lines	0 comments	Download
M	chrome/browser/ui/browser.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	2 chunks	+4 lines, -6 lines	0 comments	Download
D	ui/resources/aura/status_less.png	View	Binary file		0 comments	Download
D	ui/resources/aura/status_more.png	View	Binary file		0 comments	Download
D	ui/resources/aura/status_network_airplane.png	View	Binary file		0 comments	Download
M	ui/resources/ui_resources.grd	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages