Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 9702027: Don't use an explicit s0 in ClampDoubleToUint8. (Closed)

Created:
8 years, 9 months ago by danno
Modified:
8 years, 9 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Don't use an explicit s0 in ClampDoubleToUint8. R=fschneider@chromium.org BUG=v8:2004 TEST=test/mjsunit/pixel-array-rounding.js Committed: https://code.google.com/p/v8/source/detail?r=11053

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -2 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A test/mjsunit/pixel-array-rounding.js View 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danno
8 years, 9 months ago (2012-03-14 16:35:06 UTC) #1
fschneider
It seems that the tests in test-api/PixelArray do not exercise the optimizing compiler well enough. ...
8 years, 9 months ago (2012-03-15 09:17:05 UTC) #2
danno
8 years, 9 months ago (2012-03-15 09:51:12 UTC) #3
Agreed. The test are all pre-d8 typed array support and even
pre-OptimizeFunctionOnNextCall. However, I am going to save that for another CL,
since it's a chunk of refactoring that I don't want to couple with this fix.

On 2012/03/15 09:17:05, fschneider wrote:
> It seems that the tests in test-api/PixelArray do not exercise the optimizing
> compiler well enough.
> 
> I'd strongly prefer changing those tests so that they all hit the optimizing
> compiler (including the one extracted test case). The easiest is probably to
> move them from cctest to a mjsunit test since we now have support for
allocating
> typed arrays in d8.
> 
> LGTM, otherwise.

Powered by Google App Engine
This is Rietveld 408576698