Issue 9702026: Remove write barriers for raw smi accessors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9702026: Remove write barriers for raw smi accessors. (Closed)

Created:
8 years, 9 months ago by Yang

Modified:
8 years, 9 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove write barriers for raw smi accessors. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11048

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -15 lines)			Patch
	M	src/objects-inl.h	View		6 chunks	+29 lines, -15 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 9 months ago (2012-03-14 16:15:16 UTC) #2

LGTM (with a nit).

https://chromiumcodereview.appspot.com/9702026/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://chromiumcodereview.appspot.com/9702026/diff/1/src/objects-inl.h#newco...
src/objects-inl.h:97: // Getter that returns a raw Smi and setter that writes a
raw Smi.
I would refer to them as "tagged Smi" instead of "raw Smi".

Expand Messages | Collapse Messages