Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 9702024: ash: Take the 24h clock pref into consideration when showing the time. (Closed)

Created:
8 years, 9 months ago by sadrul
Modified:
8 years, 9 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, ben+watch_chromium.org, dhollowa+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, tfarina
Visibility:
Public.

Description

ash: Take the 24h clock pref into consideration when showing the time. R=ben@chromium.org BUG=117682 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126672

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -10 lines) Patch
M ash/ash.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ash/shell.h View 3 chunks +5 lines, -0 lines 0 comments Download
M ash/shell.cc View 3 chunks +6 lines, -0 lines 0 comments Download
A ash/system/power/date_format_observer.h View 1 chunk +19 lines, -0 lines 0 comments Download
M ash/system/power/tray_power_date.h View 3 chunks +6 lines, -1 line 0 comments Download
M ash/system/power/tray_power_date.cc View 7 chunks +18 lines, -9 lines 0 comments Download
M ash/system/tray/system_tray_delegate.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 8 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
8 years, 9 months ago (2012-03-14 15:27:14 UTC) #1
Ben Goodger (Google)
I am beginning to wonder about all this tray-specific stuff hanging directly off the shell. ...
8 years, 9 months ago (2012-03-14 16:09:10 UTC) #2
sadrul
On 2012/03/14 16:09:10, Ben Goodger (Google) wrote: > I am beginning to wonder about all ...
8 years, 9 months ago (2012-03-14 16:36:58 UTC) #3
Ben Goodger (Google)
8 years, 9 months ago (2012-03-14 16:47:16 UTC) #4
Yes. LGTM for this one.

Powered by Google App Engine
This is Rietveld 408576698