Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: chrome/browser/task_profiler/task_profiler_data_serializer_unittest.cc

Issue 9702014: [UMA] Use proper C++ objects to serialize tracked_objects across process boundaries. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix yet another IWYU for chromeos/ (take 4) Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_profiler/task_profiler_data_serializer_unittest.cc
diff --git a/chrome/browser/task_profiler/task_profiler_data_serializer_unittest.cc b/chrome/browser/task_profiler/task_profiler_data_serializer_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..5b8e56f740d477393fb22ea93e9d06b6cc848b42
--- /dev/null
+++ b/chrome/browser/task_profiler/task_profiler_data_serializer_unittest.cc
@@ -0,0 +1,161 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <string>
+
+#include "base/basictypes.h"
+#include "base/json/json_writer.h"
+#include "base/process_util.h"
+#include "base/string_number_conversions.h"
+#include "base/tracked_objects.h"
+#include "base/values.h"
+#include "chrome/browser/task_profiler/task_profiler_data_serializer.h"
+#include "content/public/common/process_type.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+std::string GetProcessIdString() {
+ return base::IntToString(base::GetCurrentProcId());
+}
+
+void ExpectSerialization(
+ const tracked_objects::ProcessDataSnapshot& process_data,
+ content::ProcessType process_type,
+ const std::string& expected_json) {
+ base::DictionaryValue serialized_value;
+ task_profiler::TaskProfilerDataSerializer::ToValue(
+ process_data, process_type, &serialized_value);
+
+ std::string serialized_json;
+ base::JSONWriter::Write(&serialized_value, &serialized_json);
+
+ EXPECT_EQ(expected_json, serialized_json);
+}
+
+} // anonymous namespace
+
+// Tests the JSON serialization format for profiled process data.
+TEST(TaskProfilerDataSerializerTest, SerializeProcessDataToJson) {
+ {
+ // Empty data.
+ tracked_objects::ProcessDataSnapshot process_data;
+ content::ProcessType process_type = content::PROCESS_TYPE_BROWSER;
+ ExpectSerialization(process_data, process_type,
+ "{"
+ "\"descendants\":["
+ "],"
+ "\"list\":["
+ "],"
+ "\"process_id\":" + GetProcessIdString() + ","
+ "\"process_type\":\"Browser\""
+ "}");
+ }
+
+ {
+ // Non-empty data.
+ tracked_objects::ProcessDataSnapshot process_data;
+
+ tracked_objects::BirthOnThreadSnapshot parent;
+ parent.location.file_name = "path/to/foo.cc";
+ parent.location.function_name = "WhizBang";
+ parent.location.line_number = 101;
+ parent.thread_name = "CrBrowserMain";
+
+ tracked_objects::BirthOnThreadSnapshot child;
+ child.location.file_name = "path/to/bar.cc";
+ child.location.function_name = "FizzBoom";
+ child.location.line_number = 433;
+ child.thread_name = "Chrome_IOThread";
+
+
+ // Add a snapshot.
+ process_data.tasks.push_back(tracked_objects::TaskSnapshot());
+ process_data.tasks.back().birth = parent;
+ process_data.tasks.back().death_data.count = 37;
+ process_data.tasks.back().death_data.run_duration_max = 5;
+ process_data.tasks.back().death_data.run_duration_sample = 3;
+ process_data.tasks.back().death_data.run_duration_sum = 17;
+ process_data.tasks.back().death_data.queue_duration_max = 53;
+ process_data.tasks.back().death_data.queue_duration_sample = 13;
+ process_data.tasks.back().death_data.queue_duration_sum = 79;
+ process_data.tasks.back().death_thread_name = "WorkerPool/-1340960768";
+
+ // Add a second snapshot.
+ process_data.tasks.push_back(tracked_objects::TaskSnapshot());
+ process_data.tasks.back().birth = child;
+ process_data.tasks.back().death_data.count = 41;
+ process_data.tasks.back().death_data.run_duration_max = 205;
+ process_data.tasks.back().death_data.run_duration_sample = 203;
+ process_data.tasks.back().death_data.run_duration_sum = 2017;
+ process_data.tasks.back().death_data.queue_duration_max = 2053;
+ process_data.tasks.back().death_data.queue_duration_sample = 2013;
+ process_data.tasks.back().death_data.queue_duration_sum = 2079;
+ process_data.tasks.back().death_thread_name = "PAC thread #3";
+
+ // Add a parent-child pair.
+ process_data.descendants.push_back(
+ tracked_objects::ParentChildPairSnapshot());
+ process_data.descendants.back().parent = parent;
+ process_data.descendants.back().child = child;
+
+ content::ProcessType process_type = content::PROCESS_TYPE_RENDERER;
+ ExpectSerialization(process_data, process_type,
+ "{"
+ "\"descendants\":["
+ "{"
+ "\"child_location\":{"
+ "\"file_name\":\"path/to/bar.cc\","
+ "\"function_name\":\"FizzBoom\","
+ "\"line_number\":433"
+ "},"
+ "\"child_thread\":\"Chrome_IOThread\","
+ "\"parent_location\":{"
+ "\"file_name\":\"path/to/foo.cc\","
+ "\"function_name\":\"WhizBang\","
+ "\"line_number\":101"
+ "},"
+ "\"parent_thread\":\"CrBrowserMain\""
+ "}"
+ "],"
+ "\"list\":[{"
+ "\"birth_location\":{"
+ "\"file_name\":\"path/to/foo.cc\","
+ "\"function_name\":\"WhizBang\","
+ "\"line_number\":101"
+ "},"
+ "\"birth_thread\":\"CrBrowserMain\","
+ "\"death_data\":{"
+ "\"count\":37,"
+ "\"queue_ms\":79,"
+ "\"queue_ms_max\":53,"
+ "\"queue_ms_sample\":13,"
+ "\"run_ms\":17,"
+ "\"run_ms_max\":5,"
+ "\"run_ms_sample\":3"
+ "},"
+ "\"death_thread\":\"WorkerPool/-1340960768\""
+ "},{"
+ "\"birth_location\":{"
+ "\"file_name\":\"path/to/bar.cc\","
+ "\"function_name\":\"FizzBoom\","
+ "\"line_number\":433"
+ "},"
+ "\"birth_thread\":\"Chrome_IOThread\","
+ "\"death_data\":{"
+ "\"count\":41,"
+ "\"queue_ms\":2079,"
+ "\"queue_ms_max\":2053,"
+ "\"queue_ms_sample\":2013,"
+ "\"run_ms\":2017,"
+ "\"run_ms_max\":205,"
+ "\"run_ms_sample\":203"
+ "},"
+ "\"death_thread\":\"PAC thread #3\""
+ "}],"
+ "\"process_id\":" + GetProcessIdString() + ","
+ "\"process_type\":\"Tab\""
+ "}");
+ }
+}
« no previous file with comments | « chrome/browser/task_profiler/task_profiler_data_serializer.cc ('k') | chrome/browser/ui/webui/profiler_ui.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698