Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: content/public/browser/profiler_subscriber.h

Issue 9702014: [UMA] Use proper C++ objects to serialize tracked_objects across process boundaries. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make sure to initialize all primitive fields Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/profiler_subscriber.h
diff --git a/content/public/browser/profiler_subscriber.h b/content/public/browser/profiler_subscriber.h
index f37947a0d067a297d279fa3e295bad11c43ef55b..0d090a3c764e7106ee07e3cf0811fcde493bea94 100644
--- a/content/public/browser/profiler_subscriber.h
+++ b/content/public/browser/profiler_subscriber.h
@@ -6,9 +6,10 @@
#define CONTENT_PUBLIC_BROWSER_PROFILER_SUBSCRIBER_H_
#include "content/common/content_export.h"
+#include "content/public/common/process_type.h"
-namespace base {
-class DictionaryValue;
+namespace tracked_objects {
+struct SerializedProcessData;
}
namespace content {
@@ -19,16 +20,17 @@ class CONTENT_EXPORT ProfilerSubscriber {
virtual ~ProfilerSubscriber() {}
// Send number of pending processes to subscriber. |end| is set to true if it
- // is the last time. This is called on UI thread.
+ // is the last time. This is called on the UI thread.
virtual void OnPendingProcesses(int sequence_number,
int pending_processes,
bool end) = 0;
- // Send profiler_data back to subscriber.
- // This is called on UI thread.
+ // Send |profiler_data| back to subscriber.
+ // This is called on the UI thread.
virtual void OnProfilerDataCollected(
int sequence_number,
- base::DictionaryValue* profiler_data) = 0;
+ const tracked_objects::SerializedProcessData& profiler_data,
+ content::ProcessType process_type) = 0;
jar (doing other things) 2012/04/04 17:55:35 jam mentioned in a nit that you don't need "conten
Ilya Sherman 2012/04/05 02:51:04 Oops. Re-fixed.
};
} // namespace content
« content/browser/profiler_controller_impl.h ('K') | « content/public/browser/profiler_controller.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698