Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Side by Side Diff: chrome/browser/resources/profiler/profiler.js

Issue 9702014: [UMA] Use proper C++ objects to serialize tracked_objects across process boundaries. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix yet another IWYU for chromeos/ (take 4) Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 var g_browserBridge; 5 var g_browserBridge;
6 var g_mainView; 6 var g_mainView;
7 7
8 // TODO(eroman): The handling of "max" across snapshots is not correct. 8 // TODO(eroman): The handling of "max" across snapshots is not correct.
9 // For starters the browser needs to be aware to generate new maximums. 9 // For starters the browser needs to be aware to generate new maximums.
10 // Secondly, we need to take into account the "max" of intermediary snapshots, 10 // Secondly, we need to take into account the "max" of intermediary snapshots,
(...skipping 349 matching lines...) Expand 10 before | Expand all | Expand 10 after
360 360
361 KEY_PROPERTIES[KEY_DEATH_THREAD] = { 361 KEY_PROPERTIES[KEY_DEATH_THREAD] = {
362 name: 'Exec thread', 362 name: 'Exec thread',
363 inputJsonKey: 'death_thread', 363 inputJsonKey: 'death_thread',
364 aggregator: UniquifyAggregator, 364 aggregator: UniquifyAggregator,
365 comparator: threadNameComparator, 365 comparator: threadNameComparator,
366 }; 366 };
367 367
368 KEY_PROPERTIES[KEY_FUNCTION_NAME] = { 368 KEY_PROPERTIES[KEY_FUNCTION_NAME] = {
369 name: 'Function name', 369 name: 'Function name',
370 inputJsonKey: 'location.function_name', 370 inputJsonKey: 'birth_location.function_name',
371 aggregator: UniquifyAggregator, 371 aggregator: UniquifyAggregator,
372 }; 372 };
373 373
374 KEY_PROPERTIES[KEY_FILE_NAME] = { 374 KEY_PROPERTIES[KEY_FILE_NAME] = {
375 name: 'File name', 375 name: 'File name',
376 inputJsonKey: 'location.file_name', 376 inputJsonKey: 'birth_location.file_name',
377 aggregator: UniquifyAggregator, 377 aggregator: UniquifyAggregator,
378 }; 378 };
379 379
380 KEY_PROPERTIES[KEY_LINE_NUMBER] = { 380 KEY_PROPERTIES[KEY_LINE_NUMBER] = {
381 name: 'Line number', 381 name: 'Line number',
382 cellAlignment: 'right', 382 cellAlignment: 'right',
383 inputJsonKey: 'location.line_number', 383 inputJsonKey: 'birth_location.line_number',
384 aggregator: UniquifyAggregator, 384 aggregator: UniquifyAggregator,
385 }; 385 };
386 386
387 KEY_PROPERTIES[KEY_COUNT] = { 387 KEY_PROPERTIES[KEY_COUNT] = {
388 name: 'Count', 388 name: 'Count',
389 cellAlignment: 'right', 389 cellAlignment: 'right',
390 sortDescending: true, 390 sortDescending: true,
391 textPrinter: formatNumberAsText, 391 textPrinter: formatNumberAsText,
392 inputJsonKey: 'death_data.count', 392 inputJsonKey: 'death_data.count',
393 aggregator: SumAggregator, 393 aggregator: SumAggregator,
(...skipping 1820 matching lines...) Expand 10 before | Expand all | Expand 10 after
2214 groupKey.push(entry); 2214 groupKey.push(entry);
2215 } 2215 }
2216 2216
2217 return JSON.stringify(groupKey); 2217 return JSON.stringify(groupKey);
2218 }; 2218 };
2219 }, 2219 },
2220 }; 2220 };
2221 2221
2222 return MainView; 2222 return MainView;
2223 })(); 2223 })();
OLDNEW
« no previous file with comments | « chrome/browser/metrics/tracking_synchronizer_observer.h ('k') | chrome/browser/task_profiler/task_profiler_data_serializer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698