[UMA] Use proper C++ objects to serialize tracked_objects across process boundaries.

chrome/browser/task_profiler/task_profiler_data_serializer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_TASK_PROFILER_TASK_PROFILER_DATA_SERIALIZER_H_
 #define CHROME_BROWSER_TASK_PROFILER_TASK_PROFILER_DATA_SERIALIZER_H_
 #pragma once
 
+#include "base/basictypes.h"
+#include "content/public/common/process_type.h"
+
 class FilePath;
 
+namespace base {
+class DictionaryValue;
+}
+
+namespace tracked_objects {
+struct ProcessDataSnapshot;
+}
+
 namespace task_profiler {
 
 // This class collects task profiler data and serializes it to a file.  The file
 // format is compatible with the about:profiler UI.
 class TaskProfilerDataSerializer {
  public:
-  bool WriteToFile(const FilePath &path);
+  TaskProfilerDataSerializer() {}
+
+  // Re-serializes |process_data| and |process_type| into |dictionary|.
+  static void SerializeToJson(

[jar (doing other things), 2012/04/09 23:32:59]

This should probably be called something more like:
ToValue().

Would it be reasonable to take the first two arguments in the constructor, and
hold the Value() representation as a member?

[Ilya Sherman, 2012/04/10 00:37:42]

Done.
Probably not, as this function is also called from profiler_ui.cc, whereas
TaskProfilerDataSerializer() is mostly geared toward serialization to disk.  If
we decide to use protocol buffers for serializing to disk, then I'll move this
code out into profiler_ui.cc.  In the meanwhile, I think it makes sense to keep
it as a static helper function here.

+      const tracked_objects::ProcessDataSnapshot& process_data,
+      content::ProcessType process_type,
+      base::DictionaryValue* dictionary);
+
+  bool WriteToFile(const FilePath& path);
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(TaskProfilerDataSerializer);
 };
 
 }  // namespace task_profiler
 
 #endif  // CHROME_BROWSER_TASK_PROFILER_TASK_PROFILER_DATA_SERIALIZER_H_