Issue 9702013: Avoid using Pickle::WriteSize(), which writes an architecture-dependent amount

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9702013: Avoid using Pickle::WriteSize(), which writes an architecture-dependent amount (Closed)

Created:
8 years, 9 months ago by Mike Mammarella

Modified:
8 years, 9 months ago

Reviewers:
sky

CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org, dcheng, jar (doing other things)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Avoid using Pickle::WriteSize(), which writes an architecture-dependent amount of data, in drag action pickles. (The goal is to remove that method entirely. Uses that never persist or send pickles over the network are [probably] safe, but having the method around is waiting for accidental misuses.) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126761

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	chrome/browser/ui/views/extensions/browser_action_drag_data.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
	M	chrome/browser/ui/views/extensions/browser_action_drag_data_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages