Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: runtime/vm/parser.cc

Issue 9702010: Compiler warning on named optional params that start with '_' (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 5448)
+++ runtime/vm/parser.cc (working copy)
@@ -893,7 +893,11 @@
// At this point, we must see an identifier for the parameter name.
parameter.name_pos = token_index_;
parameter.name = ExpectIdentifier("parameter name expected");
-
+ if (params->has_named_optional_parameters &&
+ (parameter.name->CharAt(0) == '_')) {
+ Warning(parameter.name_pos,
+ "named optional parameters may not start with '_'\n");
+ }
if (parameter.is_field_initializer) {
params->has_field_initializer = true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698